fix: rework performance parsing & error handling #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR tidies up the code around performance parsing and what we respond with from our tools. It introduces the ability to have no Insights from a trace (relatively rare, but can happen), and also adds more information to the output in the event that something went wrong. Previously we just logged errors, but if we respond with them here that will also help users report issues and increase the chances that we can debug them.
OrKoN
force-pushed
the
jackfr/noInsights
branch
from
9d50ea6 to
7155e84
Compare
OrKoN
approved these changes
Sep 23, 2025
OrKoN
pushed a commit
that referenced
this pull request
Sep 23, 2025
🤖 I have created a release *beep* *boop* --- ## [0.2.2](chrome-devtools-mcp-v0.2.1...chrome-devtools-mcp-v0.2.2) (2025-09-23) ### Bug Fixes * cli version being reported as unknown ([#74](#74)) ([d6bab91](d6bab91)) * remove unnecessary waiting for navigation ([#83](#83)) ([924c042](924c042)) * rework performance parsing & error handling ([#75](#75)) ([e8fb30c](e8fb30c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tidies up the code around performance parsing and what we
respond with from our tools. It introduces the ability to have no
Insights from a trace (relatively rare, but can happen), and also adds
more information to the output in the event that something went wrong.
Previously we just logged errors, but if we respond with them here that
will also help users report issues and increase the chances that we can
debug them.