-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: add --profile-directory option to specify Chrome profile #753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Yasindu20
wants to merge
7
commits into
ChromeDevTools:main
Choose a base branch
from
Yasindu20:support-multiple-chrome-profiles
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+144
−0
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
320e974
feat: add --profile-directory option to specify Chrome profile
Yasindu20 e15f5dc
Update src/cli.ts
Yasindu20 0abdf77
Merge branch 'main' into support-multiple-chrome-profiles
Yasindu20 08f98e4
added a validation step to detect a profile mismatch
Yasindu20 3d5da8b
Run the npm run docs to up to date the documentation
Yasindu20 276f81a
fixed the DevToolsActivePort, removed the profile-related checks from…
Yasindu20 6744657
Probe each BrowserContext
Yasindu20 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -198,6 +198,13 @@ export const cliOptions = { | |
| default: true, | ||
| describe: 'Set to false to exclude tools related to network.', | ||
| }, | ||
| profileDirectory: { | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we probably should be using https://pptr.dev/api/puppeteer.browser.browsercontexts to locate the browser context for the profile (currently the default browser context is used) |
||
| type: 'string', | ||
| description: | ||
| 'Specify which Chrome profile to use by specifying its directory name (e.g., "Profile 1", "Default") inside a chrome user data directory. Only works with --autoConnect or when launching Chrome via the Chrome DevTools MCP server.', | ||
| alias: 'profile-dir', | ||
| conflicts: ['browserUrl', 'wsEndpoint'], | ||
| }, | ||
| usageStatistics: { | ||
| type: 'boolean', | ||
| // Marked as `false` until the feature is ready to be enabled by default. | ||
|
|
@@ -273,6 +280,14 @@ export function parseArguments(version: string, argv = process.argv) { | |
| '$0 --auto-connect --channel=canary', | ||
| 'Connect to a canary Chrome instance (Chrome 145+) running instead of launching a new instance', | ||
| ], | ||
| [ | ||
| '$0 --auto-connect --profile-directory="Profile 1"', | ||
| 'Connect to Chrome using a specific profile (requires Chrome 145+)', | ||
| ], | ||
| [ | ||
| '$0 --channel=stable --profile-directory="Work Profile"', | ||
| 'Launch stable Chrome with a specific profile', | ||
| ], | ||
| ]); | ||
|
|
||
| return yargsInstance | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR does not add anything useful without the implementation for finding the browser context that matches the profileDirectory name. Passing
--profile-directoryto Chrome is already possible via the--chrome-argparam. Would you be up to figuring out how to find the correct browser context? it might right changes on the CDP and Puppeteer side.