-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix: increase timeouts for long text input #787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@OrKoN thanks for the quick fix. I tried your patch but still getting timed out, after 10 seconds this time instead of 5. |
|
@kth8 I think the agent is not quite right here because the locator.fill() ends up in keyboard.type:
We also do not want a 60 sec timeout as it is too long if there are other issues not related to typing. Perhaps we should just have a different tool like Are you sure you correctly re-built and used the server from this branch? can you reproduce the timeout by running the tests from this PR on your machine? can you try adding a test that would demonstrate the timeout? I wonder if there is some dependency on the page content? |
|
Thanks for testing! I think we will land this next week (maybe increasing timeouts linearly according to the input length, instead of per block of 1k chars). But I think I will also look into fixing the fill() method in Puppeteer to switch to pasting the entire text at once for large texts. |
fea3706 to
0f930be
Compare
0f930be to
3fec51f
Compare



Fixes #786