Skip to content

chore: Prefix logged enum flag values with their snake_case name #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OrKoN merged 1 commit into from
Jan 20, 2026
+3 −3
Merged

chore: Prefix logged enum flag values with their snake_case name #799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/telemetry/flag-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export function computeFlagUsage(
// For enums, log the value as uppercase
// We're going to have an enum for such flags with choices represented
// as an `enum` where the keys of the enum will map to the uppercase `choice`.
usage[snakeCaseName] = value.toUpperCase();
usage[snakeCaseName] = `${snakeCaseName}_${value}`.toUpperCase();
}
}

Expand Down
4 changes: 2 additions & 2 deletions tests/telemetry/flag-utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@ describe('computeFlagUsage', () => {
assert.equal(usage.bool_flag, false);
});

it('logs enum flags as uppercase', () => {
it('logs enum flags as uppercase strings prefixed by snake case flag name', () => {
const args = {enumFlag: 'a'};
const usage = computeFlagUsage(args, mockOptions);
assert.equal(usage.enum_flag, 'A');
assert.equal(usage.enum_flag, 'ENUM_FLAG_A');
});

it('logs other flags as present with snake_case keys', () => {
Expand Down