Fix heapSnapshotLoaderTest, part 1

The function heapSnapshotLoaderTest, defined in Blink, is async, but the
calling code doesn't await its result, so that test has been failing
silently for a long time. This change is the DevTools part of fixing it.

Bug: 402327008
Change-Id: I348910f1827ed176e886f5310e600cfd50c9e028
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6344191
Commit-Queue: Seth Brenith <[email protected]>
Reviewed-by: Simon Zünd <[email protected]>

Author: sethbrenith

front_end/entrypoints/heap_snapshot_worker/HeapSnapshot.ts

@@ -937,7 +937,6 @@ export abstract class HeapSnapshot {
     this.buildSamples();
     this.#progress.updateStatus('Building locations…');
     this.buildLocationMap();
-    this.#progress.updateStatus('Finished processing.');
 
     if (this.profile.snapshot.trace_function_count) {
       this.#progress.updateStatus('Building allocation statistics…');
@@ -962,8 +961,9 @@ export abstract class HeapSnapshot {
         stats.ids.push(node.id());
       }
       this.#allocationProfile = new AllocationProfile(this.profile, liveObjects);
-      this.#progress.updateStatus('done');
     }
+
+    this.#progress.updateStatus('Finished processing.');
   }
 
   private buildEdgeIndexes(): void {

front_end/entrypoints/heap_snapshot_worker/HeapSnapshotLoader.ts

@@ -45,13 +45,14 @@ export class HeapSnapshotLoader {
   #array!: Platform.TypedArrayUtilities.BigUint32Array|null;
   #arrayIndex!: number;
   #json = '';
+  parsingComplete: Promise<void>;
   constructor(dispatcher: HeapSnapshotWorkerDispatcher) {
     this.#reset();
     this.#progress = new HeapSnapshotProgress(dispatcher);
     this.#buffer = [];
     this.#dataCallback = null;
     this.#done = false;
-    void this.#parseInput();
+    this.parsingComplete = this.#parseInput();
   }
 
   dispose(): void {
@@ -254,7 +255,7 @@ export class HeapSnapshotLoader {
     const stringsTokenIndex = await this.#findToken('"strings"');
     const bracketIndex = await this.#findToken('[', stringsTokenIndex);
     this.#json = this.#json.slice(bracketIndex);
-    while (!this.#done) {
+    while (this.#buffer.length > 0 || !this.#done) {
       this.#json += await this.#fetchChunk();
     }
     this.#parseStringsArray();

front_end/entrypoints/heap_snapshot_worker/HeapSnapshotWorkerDispatcher.ts

@@ -59,7 +59,7 @@ export class HeapSnapshotWorkerDispatcher {
     this.#postMessage({eventName: name, data});
   }
 
-  dispatchMessage({data}: {data: HeapSnapshotModel.HeapSnapshotModel.WorkerCommand}): void {
+  async dispatchMessage({data}: {data: HeapSnapshotModel.HeapSnapshotModel.WorkerCommand}): Promise<void> {
     const response: DispatcherResponse =
         {callId: data.callId, result: null, error: undefined, errorCallStack: undefined, errorMethodName: undefined};
     try {
@@ -102,7 +102,7 @@ export class HeapSnapshotWorkerDispatcher {
             };
             // @ts-expect-error
             globalThis.HeapSnapshotModel = HeapSnapshotModel;
-            response.result = self.eval(data.source);
+            response.result = await self.eval(data.source);
           } catch (error) {
             response.result = error.toString();
           }

front_end/legacy_test_runner/heap_profiler_test_runner/heap_profiler_test_runner.js

@@ -59,7 +59,8 @@ HeapProfilerTestRunner.createHeapSnapshotMockFactories = function() {
           trace_node_fields: ['id', 'function_info_index', 'count', 'size', 'children']
         },
         node_count: 6,
-        edge_count: 7
+        edge_count: 7,
+        trace_function_count: 1
       },
 
       nodes: [
@@ -82,6 +83,9 @@ HeapProfilerTestRunner.createHeapSnapshotMockFactories = function() {
   HeapProfilerTestRunner.postprocessHeapSnapshotMock = function(mock) {
     mock.nodes = new Uint32Array(mock.nodes);
     mock.edges = new Uint32Array(mock.edges);
+    if (mock.trace_function_infos) {
+      mock.trace_function_infos = new Uint32Array(mock.trace_function_infos);
+    }
     mock.nodes.getValue = mock.edges.getValue = function(i) {
       return this[i];
     };