Skip to content

Commit 0e29f16

Browse files
jackfranklinDevtools-frontend LUCI CQ
authored andcommitted
RPP: fix incorrectly formatted aggregate third party time
We incorrectly cast this to microsecs but the values we are reducing are milliseconds. Bug: 394651390 Change-Id: I20b514ea3d27b49e1707b0a9358189923199c49b Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387360 Commit-Queue: Andres Olivares <[email protected]> Reviewed-by: Andres Olivares <[email protected]> Auto-Submit: Jack Franklin <[email protected]>
1 parent ce08692 commit 0e29f16

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

front_end/panels/timeline/components/insights/ThirdParties.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,10 @@ export class ThirdParties extends BaseInsightComponent<ThirdPartiesInsightModel>
5959
}),
6060
createAggregatedTableRow:
6161
remaining => {
62-
const totalMainThreadTime =
63-
remaining.reduce((acc, summary) => acc + summary.mainThreadTime, 0) as Trace.Types.Timing.Micro;
62+
const totalMainThreadTime = remaining.reduce<Trace.Types.Timing.Milli>(
63+
(acc, summary) => Trace.Types.Timing.Milli(acc + summary.mainThreadTime), Trace.Types.Timing.Milli(0));
6464
return {
65-
values:
66-
[renderOthersLabel(remaining.length), i18n.TimeUtilities.formatMicroSecondsTime(totalMainThreadTime)],
65+
values: [renderOthersLabel(remaining.length), i18n.TimeUtilities.millisToString(totalMainThreadTime)],
6766
overlays: remaining.flatMap(summary => this.#createOverlaysForSummary(summary) ?? []),
6867
};
6968
},

0 commit comments

Comments
 (0)