RPP: Delete unused methods

I found these all with some shell scripts, but them double-checked each
and then excluded ones used in tests.

Bug: 390743134
Change-Id: If30d5f23514941cc39e492f0e1033bbec794f9b9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6236186
Reviewed-by: Jack Franklin <[email protected]>
Auto-Submit: Paul Irish <[email protected]>
Commit-Queue: Jack Franklin <[email protected]>

Author: paulirish

front_end/models/trace/ModelImpl.ts

@@ -251,7 +251,3 @@ declare global {
 export function isModelUpdateDataComplete(eventData: ModelUpdateEventData): eventData is ModelUpdateEventComplete {
   return eventData.type === ModelUpdateType.COMPLETE;
 }
-
-export function isModelUpdateDataProgress(eventData: ModelUpdateEventData): eventData is ModelUpdateEventProgress {
-  return eventData.type === ModelUpdateType.PROGRESS_UPDATE;
-}

front_end/models/trace/helpers/Timing.ts

@@ -94,14 +94,6 @@ export function traceWindowMilliSeconds(bounds: Types.Timing.TraceWindowMicro):
   };
 }
 
-export function traceWindowMillisecondsToMicroSeconds(bounds: Types.Timing.TraceWindowMilli):
-    Types.Timing.TraceWindowMicro {
-  return {
-    min: milliToMicro(bounds.min),
-    max: milliToMicro(bounds.max),
-    range: milliToMicro(bounds.range),
-  };
-}
 export function traceWindowMicroSecondsToMilliSeconds(bounds: Types.Timing.TraceWindowMicro):
     Types.Timing.TraceWindowMilli {
   return {

front_end/models/trace/helpers/Trace.ts

@@ -669,11 +669,6 @@ export function eventHasCategory(event: Types.Events.Event, category: string): b
   return parsedCategoriesForEvent.has(category);
 }
 
-export function nodeIdForInvalidationEvent(event: Types.Events.InvalidationTrackingEvent): Protocol.DOM.BackendNodeId|
-    null {
-  return event.args.data.nodeId ?? null;
-}
-
 /**
  * This compares Types.Events.CallFrame with Protocol.Runtime.CallFrame and checks for equality.
  */

front_end/models/trace/lantern/graph/BaseNode.ts

@@ -132,6 +132,7 @@ class BaseNode<T = Lantern.AnyNetworkObject> {
     this.dependencies.splice(this.dependencies.indexOf(node), 1);
   }
 
+  // Unused in devtools, but used in LH.
   removeAllDependencies(): void {
     for (const node of this.dependencies.slice()) {
       this.removeDependency(node);

front_end/models/trace/lantern/graph/PageDependencyGraph.ts

@@ -556,6 +556,7 @@ class PageDependencyGraph {
     return rootNode;
   }
 
+  // Unused, but useful for debugging.
   static printGraph(rootNode: Node, widthInCharacters = 100): void {
     function padRight(str: string, target: number, padChar = ' '): string {
       return str + padChar.repeat(Math.max(target - str.length, 0));

front_end/models/trace/lantern/simulation/Simulator.ts

@@ -535,6 +535,7 @@ class Simulator<T = Lantern.AnyNetworkObject> {
     return Math.round(wastedMs / 10) * 10;
   }
 
+  // Used by Lighthouse asset-saver
   static get allNodeTimings(): Map<string, Map<Graph.Node, CompleteNodeTiming>> {
     return ALL_SIMULATION_NODE_TIMINGS;
   }

front_end/models/trace/lantern/simulation/TCPConnection.ts

@@ -70,10 +70,6 @@ class TCPConnection {
     this.warmed = warmed;
   }
 
-  isWarm(): boolean {
-    return this.warmed;
-  }
-
   isH2(): boolean {
     return this.h2;
   }

front_end/models/trace/types/Extensions.ts

@@ -24,10 +24,6 @@ export const extensionPalette = [
 
 export type ExtensionColorFromPalette = typeof extensionPalette[number];
 
-export function colorIsValid(color: string): boolean {
-  return (extensionPalette as readonly string[]).includes(color);
-}
-
 export interface ExtensionDataPayloadBase {
   color?: ExtensionColorFromPalette;
   properties?: [string, string][];

front_end/models/trace/types/TraceEvents.ts

@@ -1678,17 +1678,6 @@ export function isDrawFrame(event: Event): event is DrawFrame {
   // The extra check for INSTANT here is because in the past DrawFrame events had an ASYNC_NESTABLE_START and ASYNC_NESTABLE_END pair. We don't want to support those old events, so we have to check we are dealing with an instant event.
   return event.name === Name.DRAW_FRAME && event.ph === Phase.INSTANT;
 }
-export interface LegacyDrawFrameBegin extends Async {
-  name: Name.DRAW_FRAME;
-  ph: Phase.ASYNC_NESTABLE_START;
-  args: Args&{
-    layerTreeId: number,
-    frameSeqId: number,
-  };
-}
-export function isLegacyTraceEventDrawFrameBegin(event: Event): event is LegacyDrawFrameBegin {
-  return event.name === Name.DRAW_FRAME && event.ph === Phase.ASYNC_NESTABLE_START;
-}
 
 export interface BeginFrame extends Instant {
   name: Name.BEGIN_FRAME;

front_end/panels/lighthouse/LighthouseReportSelector.ts

@@ -61,10 +61,6 @@ export class ReportSelector {
     return this.itemByOptionElement.get(option as Element) as Item;
   }
 
-  hasCurrentSelection(): boolean {
-    return Boolean(this.selectedItem());
-  }
-
   hasItems(): boolean {
     return this.itemByOptionElement.size > 0;
   }