[Eval] Fix action blocks not showing up in eval tool

The `response` was getting marked as empty text when there is an
emulated function call in ACTION block.

This CL updates the logic to
* Save only `aidaResponse` for the eval data.
* Use `aidaResponse` in eval tool to render the response.

Bug: none
Change-Id: Ib6f966bc8c414213206e435c09ab7737cbd55893
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6434147
Reviewed-by: Alex Rudenko <[email protected]>
Commit-Queue: Ergün Erdoğmuş <[email protected]>

Author: ergunsh

front_end/models/ai_assistance/agents/AiAgent.ts

@@ -244,8 +244,7 @@ export abstract class AiAgent<T> {
    */
   readonly #structuredLog: Array<{
     request: Host.AidaClient.AidaRequest,
-    response: string,
-    aidaResponse?: Host.AidaClient.AidaResponse,
+    aidaResponse: Host.AidaClient.AidaResponse,
   }> = [];
 
   /**
@@ -651,7 +650,6 @@ export abstract class AiAgent<T> {
       #aidaFetch(request: Host.AidaClient.AidaRequest, options?: {signal?: AbortSignal}):
           AsyncGenerator<AidaFetchResult, void, void> {
     let aidaResponse: Host.AidaClient.AidaResponse|undefined = undefined;
-    let response = '';
     let rpcId: Host.AidaClient.RpcGlobalId|undefined;
 
     for await (aidaResponse of this.#aidaClient.fetch(request, options)) {
@@ -680,7 +678,6 @@ export abstract class AiAgent<T> {
         }
       }
 
-      response = aidaResponse.explanation;
       rpcId = aidaResponse.metadata.rpcGlobalId ?? rpcId;
       yield {
         rpcId,
@@ -693,10 +690,9 @@ export abstract class AiAgent<T> {
       request,
       response: aidaResponse,
     });
-    if (isDebugMode()) {
+    if (isDebugMode() && aidaResponse) {
       this.#structuredLog.push({
         request: structuredClone(request),
-        response,
         aidaResponse,
       });
       localStorage.setItem('aiAssistanceStructuredLog', JSON.stringify(this.#structuredLog));

scripts/ai_assistance/eval/index.js

@@ -156,14 +156,16 @@ const API = {
     for (const example of examples) {
       const exampleId = example.exampleId;
       const request = example.request.input || example.request.current_message.parts[0].text;
-      const response = example.response;
+      // Even though we don't collect `response` texts anymore, we still need it for backwards compatibility.
+      // TODO: Show function calling responses here as well.
+      const response = example.aidaResponse?.explanation || example.response;
       if (!examplesMap[exampleId]) {
         examplesMap[exampleId] = [];
       }
 
       examplesMap[exampleId].push({
         exampleId,
-        request: {input: request},
+        request,
         response,
       });
     }
@@ -261,7 +263,7 @@ function renderExample(container, sourceMap, {onEvaluationChange}) {
 
   let i = 0;
   for (const requestResponse of requestResponses) {
-    const text = `${requestResponse.request.input}\n\n${requestResponse.response}`;
+    const text = `${requestResponse.request}\n\n${requestResponse.response}`;
     const evaluationId = JSON.stringify({
       datasetTitle: viewState.dataId,
       exampleId,