Skip to content

Commit 235aa05

Browse files
szuendDevtools-frontend LUCI CQ
authored andcommitted
[build] Fix esbuild bundling on windows
[email protected] Bug: None Change-Id: I19a809628072e94d96a35d04ec8615412b5b68ba Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5961818 Reviewed-by: Kateryna Prokopenko <[email protected]> Commit-Queue: Kateryna Prokopenko <[email protected]> Auto-Submit: Simon Zünd <[email protected]> Commit-Queue: Simon Zünd <[email protected]>
1 parent d1d713e commit 235aa05

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

scripts/build/esbuild.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,14 @@
55
// @ts-check
66

77
const path = require('path');
8+
const os = require('os');
89

910
const devtools_paths = require('../devtools_paths.js');
1011
const devtools_plugin = require('./devtools_plugin.js');
1112

1213
// esbuild module uses binary in this path.
13-
process.env.ESBUILD_BINARY_PATH = path.join(devtools_paths.devtoolsRootPath(), 'third_party', 'esbuild', 'esbuild');
14+
const binaryName = os.type() === 'Windows_NT' ? 'esbuild.exe' : 'esbuild';
15+
process.env.ESBUILD_BINARY_PATH = path.join(devtools_paths.devtoolsRootPath(), 'third_party', 'esbuild', binaryName);
1416

1517
const entryPoints = [process.argv[2]];
1618
const outfile = process.argv[3];

0 commit comments

Comments
 (0)