[RPP] Fix calibration process broken due to minification

Also adds an e2e test.

Bug: 311438112
Change-Id: If2fe107ac83ba631e3f642ae7a08ae2c38575227
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6191409
Reviewed-by: Adam Raine <[email protected]>
Commit-Queue: Connor Clark <[email protected]>
Auto-Submit: Connor Clark <[email protected]>

Author: Connor Clark

front_end/panels/mobile_throttling/CalibrationController.ts

@@ -103,19 +103,17 @@ export class CalibrationController {
       moonEl.textContent = '🌑';
       moonEl.style.cssText = 'font-size: 5em';
     }
-    await runtimeModel.agent.invoke_evaluate({
-      expression: 'window.location.href = "about:blank"',
-    });
-    await runtimeModel.agent.invoke_evaluate({
-      expression: `(${setupTestPage})(${JSON.stringify(i18nString(UIStrings.runningCalibration))})`,
-    });
+
+    await primaryPageTarget.pageAgent().invoke_navigate({url: 'about:blank'});
+
     await runtimeModel.agent.invoke_evaluate({
       expression: `
-          ${computeBenchmarkIndex}
+          (${setupTestPage})(${JSON.stringify(i18nString(UIStrings.runningCalibration))});
+
           window.runBenchmark = () => {
             window.runs = window.runs ?? 0;
-            moon.textContent = ['🌑', '🌒','🌓', '🌔', '🌕', '🌖', '🌗', '🌘'][window.runs++ % 8];
-            return computeBenchmarkIndex(${benchmarkDurationMs});
+            moon.textContent = ['🌑', '🌒', '🌓', '🌔', '🌕', '🌖', '🌗', '🌘'][window.runs++ % 8];
+            return (${computeBenchmarkIndex})(${benchmarkDurationMs});
           }`,
     });
 
@@ -144,7 +142,11 @@ export class CalibrationController {
       expression: 'runBenchmark()',
     });
     if (!Number.isFinite(result.value)) {
-      throw new Error(`unexpected score from benchmark: ${result.value}`);
+      let err = `unexpected score from benchmark: ${result.value}`;
+      if (result.description) {
+        err += `\n${result.description}`;
+      }
+      throw new Error(err);
     }
     return result.value;
   }

front_end/panels/mobile_throttling/ThrottlingSettingsTab.ts

@@ -157,7 +157,7 @@ const UIStrings = {
    *@description Text to explain how the CPU calibration process will work.
    */
   calibrationConfirmationPrompt:
-      'Calibration will take ~10 seconds, and temporarily navigate away from your current page. Do you wish to continue?',
+      'Calibration will take ~5 seconds, and temporarily navigate away from your current page. Do you wish to continue?',
   /**
    *@description Text to explain an issue that may impact the CPU calibration process.
    */

test/e2e/BUILD.gn

@@ -48,6 +48,7 @@ node_ts_library("tests") {
     "snippets",
     "sources",
     "targets",
+    "throttling",
     "webaudio",
   ]
   sources = [ "mocharc.ts" ]

test/e2e/throttling/BUILD.gn

@@ -0,0 +1,14 @@
+# Copyright 2025 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import("../../../scripts/build/typescript/typescript.gni")
+
+node_ts_library("throttling") {
+  sources = [ "cpu_calibration_test.ts" ]
+
+  deps = [
+    "../../shared",
+    "../helpers",
+  ]
+}

test/e2e/throttling/cpu_calibration_test.ts

@@ -0,0 +1,32 @@
+// Copyright 2025 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import {assert} from 'chai';
+
+import {
+  click,
+  getAllTextContents,
+  waitForElementWithTextContent,
+} from '../../shared/helper.js';
+import {openSettingsTab} from '../helpers/settings-helpers.js';
+
+describe('CPU Calibration', () => {
+  it('works', async () => {
+    await openSettingsTab('Throttling');
+
+    assert.deepEqual(await getAllTextContents('.cpu-preset-result'), ['Needs calibration', 'Needs calibration']);
+
+    await waitForElementWithTextContent(
+        'To use the CPU throttling presets, run the calibration process to determine the ideal throttling rate for your device.');
+    await click('.calibrate-button');
+    await waitForElementWithTextContent(
+        'Calibration will take ~5 seconds, and temporarily navigate away from your current page. Do you wish to continue?');
+    await click('.calibrate-button');
+    await waitForElementWithTextContent('Recalibrate');
+
+    const results = await getAllTextContents('.cpu-preset-result');
+    assert.include(results[0], 'slowdown');
+    assert.include(results[1], 'slowdown');
+  });
+});