AI: fix selection of Performance agents

Bug: 394552594
Change-Id: Ia7908f4ab3ec58ddc1abd10f76a210cd070ed9b9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6257568
Commit-Queue: Jack Franklin <[email protected]>
Reviewed-by: Nikolay Vitkov <[email protected]>
Auto-Submit: Jack Franklin <[email protected]>

Author: jackfranklin

front_end/panels/ai_assistance/AiAssistancePanel.test.ts

@@ -689,6 +689,84 @@ describeWithEnvironment('FreestylerPanel', () => {
       assert.deepEqual(mockView.lastCall.args[0].agentType, AiAssistance.AgentType.STYLING);
     });
 
+    it('should select the performance insights agent if it is enabled', async () => {
+      Object.assign(Root.Runtime.hostConfig, {
+        devToolsAiAssistancePerformanceAgent: {
+          enabled: true,
+          insightsEnabled: true,
+        },
+      });
+      panel = new AiAssistance.AiAssistancePanel(mockView, {
+        aidaClient: mockAidaClient([[{explanation: 'test'}]]),
+        aidaAvailability: Host.AidaClient.AidaAccessPreconditions.AVAILABLE,
+        syncInfo: getTestSyncInfo(),
+      });
+      panel.handleAction('freestyler.elements-floating-button');
+      mockView.lastCall.args[0].onTextSubmit('test');
+      await drainMicroTasks();
+      UI.Context.Context.instance().setFlavor(
+          TimelinePanel.TimelinePanel.TimelinePanel,
+          sinon.createStubInstance(TimelinePanel.TimelinePanel.TimelinePanel));
+
+      assert.deepEqual(mockView.lastCall.args[0].messages, [
+        {
+          entity: AiAssistance.ChatMessageEntity.USER,
+          text: 'test',
+        },
+        {
+          answer: 'test',
+          entity: AiAssistance.ChatMessageEntity.MODEL,
+          rpcId: undefined,
+          suggestions: undefined,
+          steps: [],
+        },
+      ]);
+      const button = panel.contentElement.querySelector('devtools-button[aria-label=\'New chat\']');
+      assert.instanceOf(button, HTMLElement);
+      dispatchClickEvent(button);
+      assert.deepEqual(mockView.lastCall.args[0].messages, []);
+      assert.deepEqual(mockView.lastCall.args[0].agentType, AiAssistance.AgentType.PERFORMANCE_INSIGHT);
+    });
+
+    it('should select the Dr Jones performance agent if insights are not enabled', async () => {
+      Object.assign(Root.Runtime.hostConfig, {
+        devToolsAiAssistancePerformanceAgent: {
+          enabled: true,
+          insightsEnabled: false,
+        },
+      });
+      panel = new AiAssistance.AiAssistancePanel(mockView, {
+        aidaClient: mockAidaClient([[{explanation: 'test'}]]),
+        aidaAvailability: Host.AidaClient.AidaAccessPreconditions.AVAILABLE,
+        syncInfo: getTestSyncInfo(),
+      });
+      panel.handleAction('freestyler.elements-floating-button');
+      mockView.lastCall.args[0].onTextSubmit('test');
+      await drainMicroTasks();
+      UI.Context.Context.instance().setFlavor(
+          TimelinePanel.TimelinePanel.TimelinePanel,
+          sinon.createStubInstance(TimelinePanel.TimelinePanel.TimelinePanel));
+
+      assert.deepEqual(mockView.lastCall.args[0].messages, [
+        {
+          entity: AiAssistance.ChatMessageEntity.USER,
+          text: 'test',
+        },
+        {
+          answer: 'test',
+          entity: AiAssistance.ChatMessageEntity.MODEL,
+          rpcId: undefined,
+          suggestions: undefined,
+          steps: [],
+        },
+      ]);
+      const button = panel.contentElement.querySelector('devtools-button[aria-label=\'New chat\']');
+      assert.instanceOf(button, HTMLElement);
+      dispatchClickEvent(button);
+      assert.deepEqual(mockView.lastCall.args[0].messages, []);
+      assert.deepEqual(mockView.lastCall.args[0].agentType, AiAssistance.AgentType.PERFORMANCE);
+    });
+
     it('should switch agents and restore history', async () => {
       panel = new AiAssistance.AiAssistancePanel(mockView, {
         aidaClient: mockAidaClient([[{explanation: 'test'}], [{explanation: 'test2'}]]),

front_end/panels/ai_assistance/AiAssistancePanel.ts

@@ -442,12 +442,12 @@ export class AiAssistancePanel extends UI.Panel.Panel {
       targetAgentType = AgentType.NETWORK;
     } else if (isSourcesPanelVisible && hostConfig.devToolsAiAssistanceFileAgent?.enabled) {
       targetAgentType = AgentType.FILE;
-    } else if (isPerformancePanelVisible && hostConfig.devToolsAiAssistancePerformanceAgent?.enabled) {
-      targetAgentType = AgentType.PERFORMANCE;
     } else if (
         isPerformancePanelVisible && hostConfig.devToolsAiAssistancePerformanceAgent?.enabled &&
         hostConfig.devToolsAiAssistancePerformanceAgent?.insightsEnabled) {
       targetAgentType = AgentType.PERFORMANCE_INSIGHT;
+    } else if (isPerformancePanelVisible && hostConfig.devToolsAiAssistancePerformanceAgent?.enabled) {
+      targetAgentType = AgentType.PERFORMANCE;
     }
 
     const agent = targetAgentType ? this.#createAgent(targetAgentType) : undefined;