Skip to content

Commit 573a76b

Browse files
OrKoNDevtools-frontend LUCI CQ
authored andcommitted
Migrate test/e2e/elements/sidebar-event-listeners-remove_test.ts
Fixed: 416405447 Change-Id: Ica607f79073616cdaf31f549ec813a0cba75f007 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6837820 Reviewed-by: Philip Pfaffe <[email protected]> Commit-Queue: Alex Rudenko <[email protected]> Commit-Queue: Philip Pfaffe <[email protected]> Auto-Submit: Alex Rudenko <[email protected]>
1 parent c7ea2e2 commit 573a76b

File tree

5 files changed

+29
-135
lines changed

5 files changed

+29
-135
lines changed

test/e2e/elements/BUILD.gn

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ node_ts_library("elements") {
1212
"layout-pane_test.ts",
1313
"selection-after-delete_test.ts",
1414
"shadowroot-styles_test.ts",
15-
"sidebar-event-listeners-remove_test.ts",
1615
"style-pane-properties_test.ts",
1716
"styles-disable-inherited_test.ts",
1817
]

test/e2e/elements/sidebar-event-listeners-remove_test.ts

Lines changed: 0 additions & 44 deletions
This file was deleted.

test/e2e/helpers/BUILD.gn

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ node_ts_library("helpers") {
1717
"datagrid-helpers.ts",
1818
"elements-helpers.ts",
1919
"emulation-helpers.ts",
20-
"event-listeners-helpers.ts",
2120
"extension-helpers.ts",
2221
"issues-helpers.ts",
2322
"layers-helpers.ts",

test/e2e/helpers/event-listeners-helpers.ts

Lines changed: 0 additions & 89 deletions
This file was deleted.

test/e2e_non_hosted/elements/sidebar-event-listeners_test.ts

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,4 +157,33 @@ describe('Event listeners in the elements sidebar', () => {
157157
['handler', '() => console.log(\'test\')'],
158158
]);
159159
});
160+
161+
it('shows delete button by each node for a given event', async ({devToolsPage, inspectedPage}) => {
162+
await loadEventListenersAndSelectButtonNode(devToolsPage, inspectedPage);
163+
await openEventListenersPaneAndWaitForListeners(devToolsPage);
164+
const {
165+
firstListenerText,
166+
listenerSelector,
167+
} = await getFirstNodeForEventListener(devToolsPage, '[aria-label="click, event listener"]');
168+
169+
// Check that we have the right event for the right element
170+
// and that it has the delete button within it.
171+
assert.include(firstListenerText, 'button#test-button');
172+
const removeButtonSelector = `${listenerSelector} devtools-button`;
173+
const removeButton = await devToolsPage.waitFor(removeButtonSelector);
174+
if (!removeButton) {
175+
assert.fail(`Could not find remove button with selector ${removeButtonSelector}`);
176+
}
177+
const buttonTitle = await removeButton.evaluate(n => {
178+
const button = n.shadowRoot?.querySelector('button');
179+
return button?.title;
180+
});
181+
assert.strictEqual(buttonTitle, 'Delete event listener');
182+
183+
await devToolsPage.click(removeButtonSelector);
184+
185+
// now we can check that the 'click' event is gone
186+
const eventListenerNames = await getDisplayedEventListenerNames(devToolsPage);
187+
assert.deepEqual(eventListenerNames, ['custom event', 'hover']);
188+
});
160189
});

0 commit comments

Comments
 (0)