Skip to content

Commit 6c0067e

Browse files
Lightning00BladeDevtools-frontend LUCI CQ
authored andcommitted
Re-add aria-label to Dock toolbar elements
This broke the CXX debugging extension test. Change was introduced in https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6187060 Bug: none Change-Id: I1872e5be67def5185f3e73ad0ede070cde189e16 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6252832 Reviewed-by: Philip Pfaffe <[email protected]> Commit-Queue: Nikolay Vitkov <[email protected]>
1 parent 406149a commit 6c0067e

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

front_end/entrypoints/main/MainImpl.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -885,6 +885,7 @@ export class MainMenuItem implements UI.Toolbar.Provider {
885885
<devtools-button class="toolbar-button"
886886
jslog=${VisualLogging.toggle().track({click: true}).context('current-dock-state-undock')}
887887
title=${i18nString(UIStrings.undockIntoSeparateWindow)}
888+
aria-label=${i18nString(UIStrings.undockIntoSeparateWindow)}
888889
.iconName=${'dock-window'}
889890
.toggled=${dockController.dockSide() === UI.DockController.DockState.UNDOCKED}
890891
.toggledIconName=${'dock-window'}
@@ -894,6 +895,7 @@ export class MainMenuItem implements UI.Toolbar.Provider {
894895
<devtools-button class="toolbar-button"
895896
jslog=${VisualLogging.toggle().track({click: true}).context('current-dock-state-left')}
896897
title=${i18nString(UIStrings.dockToLeft)}
898+
aria-label=${i18nString(UIStrings.dockToLeft)}
897899
.iconName=${'dock-left'}
898900
.toggled=${dockController.dockSide() === UI.DockController.DockState.LEFT}
899901
.toggledIconName=${'dock-left'}
@@ -903,6 +905,7 @@ export class MainMenuItem implements UI.Toolbar.Provider {
903905
<devtools-button class="toolbar-button"
904906
jslog=${VisualLogging.toggle().track({click: true}).context('current-dock-state-bottom')}
905907
title=${i18nString(UIStrings.dockToBottom)}
908+
aria-label=${i18nString(UIStrings.dockToBottom)}
906909
.iconName=${'dock-bottom'}
907910
.toggled=${dockController.dockSide() === UI.DockController.DockState.BOTTOM}
908911
.toggledIconName=${'dock-bottom'}
@@ -912,6 +915,7 @@ export class MainMenuItem implements UI.Toolbar.Provider {
912915
<devtools-button class="toolbar-button"
913916
jslog=${VisualLogging.toggle().track({click: true}).context('current-dock-state-right')}
914917
title=${i18nString(UIStrings.dockToRight)}
918+
aria-label=${i18nString(UIStrings.dockToRight)}
915919
.iconName=${'dock-right'}
916920
.toggled=${dockController.dockSide() === UI.DockController.DockState.RIGHT}
917921
.toggledIconName=${'dock-right'}

0 commit comments

Comments
 (0)