[DrJones] Explicitly call requestContentData to make sure file content is available for Files AI Assistant.

Bug: 381071361
Change-Id: I844b0b4d9c29ff452b0392896158dfe481da9176
Fixed: 381071361
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6051598
Reviewed-by: Alex Rudenko <[email protected]>
Commit-Queue: Samiya Caur <[email protected]>

Author: Samiya Caur

front_end/panels/freestyler/AiAgent.ts

@@ -148,6 +148,14 @@ export abstract class ConversationContext<T> {
     // https://html.spec.whatwg.org/#ascii-serialisation-of-an-origin.
     return this.getOrigin() === agentOrigin;
   }
+
+  /**
+   * This method is called at the start of `AiAgent.run`.
+   * It will be overriden in subclasses to fetch data related to the context item.
+   */
+  async refresh(): Promise<void> {
+    return;
+  }
 }
 
 export abstract class AiAgent<T> {
@@ -408,6 +416,8 @@ STOP`;
       throw new Error('History entries are read-only.');
     }
 
+    await options.selected?.refresh();
+
     // First context set on the agent determines its origin from now on.
     if (options.selected && this.#origin === undefined && options.selected) {
       this.#origin = options.selected.getOrigin();

front_end/panels/freestyler/DrJonesFileAgent.test.ts

@@ -137,6 +137,7 @@ describeWithMockConnection('DrJonesFileAgent', () => {
     mimeType?: string,
     url?: Platform.DevToolsPath.UrlString,
     resourceType?: Common.ResourceType.ResourceType,
+    requestContentData?: boolean,
   }): Promise<Workspace.UISourceCode.UISourceCode> {
     const url = options?.url ?? 'http://example.test/script.js' as Platform.DevToolsPath.UrlString;
     const {project} = createContentProviderUISourceCodes({
@@ -152,98 +153,118 @@ describeWithMockConnection('DrJonesFileAgent', () => {
     });
 
     const uiSourceCode = project.uiSourceCodeForURL(url);
-
     if (!uiSourceCode) {
       throw new Error('Failed to create a test uiSourceCode');
     }
-    await uiSourceCode.requestContentData();
+    if (!uiSourceCode.contentType().isTextType()) {
+      uiSourceCode?.setContent('binary', true);
+    }
+    if (options?.requestContentData) {
+      await uiSourceCode.requestContentData();
+    }
     return uiSourceCode;
   }
 
   describe('run', () => {
-    it('generates an answer', async () => {
-      async function* generateAnswer() {
-        yield {
-          explanation: 'This is the answer',
-          metadata: {
-            rpcGlobalId: 123,
-          },
-          completed: true,
-        };
-      }
+    const testArguments = [
+      {
+        name: 'content loaded',
+        requestContentData: true,
+      },
+      {
+        name: 'content not loaded',
+        requestContentData: false,
+      },
+    ];
 
-      const agent = new DrJonesFileAgent({
-        aidaClient: mockAidaClient(generateAnswer),
-      });
+    testArguments.forEach(args => {
+      it('generates an answer ' + args.name, async () => {
+        async function* generateAnswer() {
+          yield {
+            explanation: 'This is the answer',
+            metadata: {
+              rpcGlobalId: 123,
+            },
+            completed: true,
+          };
+        }
 
-      const uiSourceCode = await createUISourceCode();
-      const responses =
-          await Array.fromAsync(agent.run('test', {selected: uiSourceCode ? new FileContext(uiSourceCode) : null}));
+        const agent = new DrJonesFileAgent({
+          aidaClient: mockAidaClient(generateAnswer),
+        });
 
-      assert.deepStrictEqual(responses, [
-        {
-          type: ResponseType.USER_QUERY,
-          query: 'test',
-        },
-        {
-          type: ResponseType.CONTEXT,
-          title: 'Analyzing file',
-          details: [
-            {
-              title: 'Selected file',
-              text: `File name: script.js
+        const uiSourceCode = await createUISourceCode({
+          requestContentData: args.requestContentData,
+          content: 'content',
+        });
+        const responses =
+            await Array.fromAsync(agent.run('test', {selected: uiSourceCode ? new FileContext(uiSourceCode) : null}));
+
+        assert.deepStrictEqual(responses, [
+          {
+            type: ResponseType.USER_QUERY,
+            query: 'test',
+          },
+          {
+            type: ResponseType.CONTEXT,
+            title: 'Analyzing file',
+            details: [
+              {
+                title: 'Selected file',
+                text: `File name: script.js
 URL: http://example.test/script.js
 File content:
 \`\`\`
-
+content
 \`\`\``,
-            },
-          ],
-        },
-        {
-          type: ResponseType.QUERYING,
-          query: `# Selected file
+              },
+            ],
+          },
+          {
+            type: ResponseType.QUERYING,
+            query: `# Selected file
 File name: script.js
 URL: http://example.test/script.js
 File content:
 \`\`\`
-
+content
 \`\`\`
 
 # User request
 
 test`,
-        },
-        {
-          type: ResponseType.ANSWER,
-          text: 'This is the answer',
-          suggestions: undefined,
-          rpcId: 123,
-        },
-      ]);
+          },
+          {
+            type: ResponseType.ANSWER,
+            text: 'This is the answer',
+            suggestions: undefined,
+            rpcId: 123,
+          },
+        ]);
 
-      assert.deepStrictEqual(agent.chatHistoryForTesting, [
-        {
-          role: 1,
-          parts: [{
-            text: `# Selected file
+        assert.deepStrictEqual(agent.chatHistoryForTesting, [
+          {
+            role: 1,
+            parts: [{
+              text: `# Selected file
 File name: script.js
 URL: http://example.test/script.js
 File content:
 \`\`\`
-
+content
 \`\`\`
 
 # User request
 
 test`,
-          }],
-        },
-        {
-          role: 2,
-          parts: [{text: 'This is the answer'}],
-        },
-      ]);
+            }],
+          },
+          {
+            role: 2,
+            parts: [{text: 'This is the answer'}],
+          },
+        ]);
+      });
     });
   });
 
@@ -267,6 +288,7 @@ test`,
     it('formats file content', async () => {
       const uiSourceCode = await createUISourceCode({
         content: 'lorem ipsum',
+        requestContentData: true,
       });
       assert.strictEqual(formatFile(uiSourceCode), `File name: script.js
 URL: http://example.test/script.js
@@ -281,6 +303,7 @@ lorem ipsum
         resourceType: Common.ResourceType.resourceTypes.Image,
         mimeType: 'application/png',
         url: 'http://example.test/test.png' as Platform.DevToolsPath.UrlString,
+        requestContentData: true,
       });
       assert.strictEqual(formatFile(uiSourceCode), `File name: test.png
 URL: http://example.test/test.png
@@ -293,6 +316,7 @@ File content:
     it('truncates long file content', async () => {
       const uiSourceCode = await createUISourceCode({
         content: 'lorem ipsum'.repeat(10_000),
+        requestContentData: true,
       });
       assert.strictEqual(formatFile(uiSourceCode), `File name: script.js
 URL: http://example.test/script.js

front_end/panels/freestyler/DrJonesFileAgent.ts

@@ -94,6 +94,10 @@ export class FileContext extends ConversationContext<Workspace.UISourceCode.UISo
   override getTitle(): string {
     return this.#file.displayName();
   }
+
+  override async refresh(): Promise<void> {
+    await this.#file.requestContentData();
+  }
 }
 
 /**
@@ -171,7 +175,8 @@ ${formatFileContent(selectedFile)}`,
 }
 
 function formatFileContent(selectedFile: Workspace.UISourceCode.UISourceCode): string {
-  const content = selectedFile.contentType().isTextType() ? selectedFile.content() : '<binary data>';
+  const contentData = selectedFile.workingCopyContentData();
+  const content = contentData.isTextContent ? contentData.text : '<binary data>';
   const truncated = content.length > MAX_FILE_SIZE ? content.slice(0, MAX_FILE_SIZE) + '...' : content;
   return `\`\`\`
 ${truncated}