Skip to content

Commit 841c0d7

Browse files
Adriana IxbaDevtools-frontend LUCI CQ
authored andcommitted
[RPP] fix entity mapper initialized to null bug
When trying to initialize the timelineDetailsView, entity mapper comes back null. Initializing earlier before other work is done seems to fix this Bug:None Change-Id: I125e3be92f2585d279797695ac9ed4bf439443a9 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6191071 Reviewed-by: Adam Raine <[email protected]> Commit-Queue: Adriana Ixba <[email protected]>
1 parent 3f47984 commit 841c0d7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

front_end/panels/timeline/TimelineFlameChartView.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1101,6 +1101,7 @@ export class TimelineFlameChartView extends Common.ObjectWrapper.eventMixin<Even
11011101
this.#selectedGroupName = null;
11021102
this.#parsedTrace = newParsedTrace;
11031103
this.#traceMetadata = traceMetadata;
1104+
this.#entityMapper = new Utils.EntityMapper.EntityMapper(this.#parsedTrace);
11041105
Common.EventTarget.removeEventListeners(this.eventListeners);
11051106
this.#selectedEvents = null;
11061107
this.mainDataProvider.setModel(newParsedTrace, isCpuProfile);
@@ -1111,7 +1112,6 @@ export class TimelineFlameChartView extends Common.ObjectWrapper.eventMixin<Even
11111112
this.refreshMainFlameChart();
11121113
this.#updateFlameCharts();
11131114
this.setMarkers(newParsedTrace);
1114-
this.#entityMapper = new Utils.EntityMapper.EntityMapper(this.#parsedTrace);
11151115
}
11161116

11171117
setInsights(

0 commit comments

Comments
 (0)