[AI] Do not send an empty string as a model id

Bug: none
Change-Id: I50bdde2a8275d279f8578ed2edf10a706c962b35
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6308775
Commit-Queue: Alex Rudenko <[email protected]>
Reviewed-by: Nikolay Vitkov <[email protected]>

Author: OrKoN

front_end/core/host/AidaClient.test.ts

@@ -144,6 +144,33 @@ describeWithEnvironment('AidaClient', () => {
     });
   });
 
+  it('adds no model id if configured as empty string', () => {
+    updateHostConfig({
+      aidaAvailability: {
+        disallowLogging: false,
+      },
+      devToolsConsoleInsights: {
+        enabled: true,
+        modelId: '',
+        temperature: 0.5,
+      },
+    });
+    const request = Host.AidaClient.AidaClient.buildConsoleInsightsRequest('foo');
+    assert.deepEqual(request, {
+      current_message: {parts: [{text: 'foo'}], role: Host.AidaClient.Role.USER},
+      client: 'CHROME_DEVTOOLS',
+      options: {
+        temperature: 0.5,
+      },
+      client_feature: 1,
+      functionality_type: 2,
+      metadata: {
+        disable_user_content_logging: false,
+        client_version: 'unit_test',
+      },
+    });
+  });
+
   it('adds metadata to disallow logging', () => {
     updateHostConfig({
       aidaAvailability: {

front_end/core/host/AidaClient.ts

@@ -267,12 +267,6 @@ export class AidaBlockError extends Error {}
 export class AidaClient {
   static buildConsoleInsightsRequest(input: string): AidaRequest {
     const {hostConfig} = Root.Runtime;
-    let temperature = -1;
-    let modelId = '';
-    if (hostConfig.devToolsConsoleInsights?.enabled) {
-      temperature = hostConfig.devToolsConsoleInsights.temperature ?? -1;
-      modelId = hostConfig.devToolsConsoleInsights.modelId || '';
-    }
     const disallowLogging = hostConfig.aidaAvailability?.disallowLogging ?? true;
     const chromeVersion = Root.Runtime.getChromeVersion();
     if (!chromeVersion) {
@@ -289,6 +283,12 @@ export class AidaClient {
       },
     };
 
+    let temperature = -1;
+    let modelId;
+    if (hostConfig.devToolsConsoleInsights?.enabled) {
+      temperature = hostConfig.devToolsConsoleInsights.temperature ?? -1;
+      modelId = hostConfig.devToolsConsoleInsights.modelId;
+    }
     if (temperature >= 0) {
       request.options ??= {};
       request.options.temperature = temperature;

front_end/panels/ai_assistance/agents/AiAgent.test.ts

@@ -87,6 +87,14 @@ describeWithEnvironment('AiAgent', () => {
       );
     });
 
+    it('builds a request without a model id it is configured as an empty string', async () => {
+      const agent = new AiAgentMock({
+        aidaClient: mockAidaClient(),
+      });
+      agent.options.modelId = '';
+      assert.isUndefined(agent.buildRequest({text: 'test input'}, Host.AidaClient.Role.USER).options?.model_id);
+    });
+
     it('builds a request with logging', async () => {
       const agent = new AiAgentMock({
         aidaClient: mockAidaClient(),

front_end/panels/ai_assistance/agents/AiAgent.ts

@@ -302,7 +302,7 @@ export abstract class AiAgent<T> {
       ...(enableAidaFunctionCalling ? {function_declarations: declarations} : {}),
       options: {
         temperature: validTemperature(this.options.temperature),
-        model_id: this.options.modelId,
+        model_id: this.options.modelId || undefined,
       },
       metadata: {
         disable_user_content_logging: !(this.#serverSideLoggingEnabled ?? false),