[RPP] Always show insights tab in the sidebar

Justification:

- It's not super clear that disabling the insights tab means all the
  insights are passing.
- The information in passed insights can be somewhat useful
- If there aren't any insights then there probably isn't anything
  worth annotating either.
- Auto switching to annotations tab makes annotations the default
  tab for the next trace loaded, which could have useful insights.

This does not affect the behavior of RPP when dealing with the brief
pre-navigation period before record and reload runs. This <50ms
period will still be excluded from the insight set entirely.

Bug: None
Change-Id: Ic224b5048446b84b6cbe76d2512607c33614c5a3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6220265
Auto-Submit: Adam Raine <[email protected]>
Commit-Queue: Connor Clark <[email protected]>
Commit-Queue: Adam Raine <[email protected]>
Reviewed-by: Connor Clark <[email protected]>

Author: Adam Raine

front_end/panels/timeline/TimelinePanel.ts

@@ -1982,18 +1982,7 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
     }
     this.statusPane?.updateProgressBar(i18nString(UIStrings.processed), 70);
 
-    let traceInsightsSets = this.#traceEngineModel.traceInsights(traceIndex);
-    if (traceInsightsSets) {
-      // Omit insight sets that don't have anything of interest to show to the user.
-      const filteredTraceInsightsSets = new Map();
-      for (const [key, insightSet] of traceInsightsSets) {
-        if (Object.values(insightSet.model).some(model => model.shouldShow)) {
-          filteredTraceInsightsSets.set(key, insightSet);
-        }
-      }
-
-      traceInsightsSets = filteredTraceInsightsSets.size ? filteredTraceInsightsSets : null;
-    }
+    const traceInsightsSets = this.#traceEngineModel.traceInsights(traceIndex);
     this.flameChart.setInsights(traceInsightsSets, this.#eventToRelatedInsights);
 
     this.flameChart.setModel(parsedTrace, traceMetadata);

front_end/panels/timeline/components/Sidebar.ts

@@ -88,10 +88,8 @@ export class SidebarWidget extends UI.Widget.VBox {
     // Swap to the Annotations tab if:
     // 1. Insights is currently selected.
     // 2. The Insights tab is disabled (which means we have no insights for this trace)
-    // 3. The annotations tab exists (we can remove this check once annotations
-    //    are non-experimental)
     if (this.#tabbedPane.selectedTabId === SidebarTabs.INSIGHTS &&
-        this.#tabbedPane.tabIsDisabled(SidebarTabs.INSIGHTS) && this.#tabbedPane.hasTab(SidebarTabs.ANNOTATIONS)) {
+        this.#tabbedPane.tabIsDisabled(SidebarTabs.INSIGHTS)) {
       this.#tabbedPane.selectTab(SidebarTabs.ANNOTATIONS);
     }
   }