Skip to content

Commit 98d493a

Browse files
ktranDevtools-frontend LUCI CQ
authored andcommitted
[GM3Restyling] Update AI settings to align with other setting tabs
This adapts the AI settings tab to the other updated settings pages. In particular: * Removing the header * Adjusting the paddings on top of the settings container wrapper * Updating the card shadow Before: https://i.imgur.com/S0woW7I.png After: https://i.imgur.com/yyHnN8J.png Fixed: 368238837 Change-Id: Id0ee9055b5b55b856a1db005f667ef1aa5122a2b Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6003766 Reviewed-by: Ergün Erdoğmuş <[email protected]> Commit-Queue: Ergün Erdoğmuş <[email protected]> Auto-Submit: Kim-Anh Tran <[email protected]>
1 parent a370911 commit 98d493a

File tree

2 files changed

+3
-21
lines changed

2 files changed

+3
-21
lines changed

front_end/panels/settings/AISettingsTab.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -138,10 +138,6 @@ const UIStrings = {
138138
*@description Label for a link to the privacy notice
139139
*/
140140
privacyNotice: 'Google Privacy Policy',
141-
/**
142-
*@description Header for the AI innovations settings page
143-
*/
144-
aiInnovations: 'AI innovations',
145141
/**
146142
*@description Label for a toggle to enable the Console Insights feature
147143
*/
@@ -536,9 +532,6 @@ export class AISettingsTab extends LegacyWrapper.LegacyWrapper.WrappableComponen
536532
// Disabled until https://crbug.com/1079231 is fixed.
537533
// clang-format off
538534
LitHtml.render(html`
539-
<header>
540-
<h1>${i18nString(UIStrings.aiInnovations)}</h1>
541-
</header>
542535
<div class="settings-container-wrapper" jslog=${VisualLogging.pane('chrome-ai')}>
543536
${this.#renderSharedDisclaimer()}
544537
${this.#consoleInsightsSetting || this.#aiAssistanceSetting ? html`

front_end/panels/settings/aiSettingsTab.css

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,6 @@
88
box-sizing: border-box;
99
}
1010

11-
header > h1 {
12-
font-size: 18px;
13-
font-weight: normal;
14-
margin: 0;
15-
white-space: nowrap;
16-
}
17-
1811
.shared-disclaimer {
1912
background: linear-gradient(135deg, var(--sys-color-gradient-primary), var(--sys-color-gradient-tertiary));
2013
border-radius: var(--sys-size-5);
@@ -45,7 +38,7 @@ header > h1 {
4538
display: grid;
4639
grid-template-columns: 1fr auto auto;
4740
border-radius: var(--sys-size-5);
48-
box-shadow: var(--sys-elevation-level3); /* stylelint-disable-line plugin/use_theme_colors */
41+
box-shadow: var(--sys-elevation-level2);
4942
margin: var(--sys-size-11) 0 var(--sys-size-4);
5043
line-height: var(--sys-typescale-body5-line-height);
5144
min-width: var(--sys-size-28);
@@ -154,13 +147,9 @@ header > h1 {
154147

155148
.settings-container-wrapper {
156149
position: absolute;
157-
top: 31px;
158-
left: 0;
159-
right: 0;
160-
bottom: 0;
150+
inset: var(--sys-size-8) 0 0;
161151
overflow: auto;
162-
padding: var(--sys-size-6);
163-
border-top: 1px solid var(--sys-color-divider);
152+
padding: var(--sys-size-3) var(--sys-size-6) var(--sys-size-6);
164153
display: flex;
165154
flex-direction: column;
166155
}

0 commit comments

Comments
 (0)