Skip to content

Commit 9b51dd8

Browse files
szuendDevtools-frontend LUCI CQ
authored andcommitted
[workspace] Extract ignore list settings into new workspace-meta.ts
We moved the IgnoreListManager from sdk/ to workspace/ but not the settings registration yet. Note that these technically need to be `moduleSetting`s, but to reduce the risk of breakage we just keep that as-is. [email protected] Bug: 458180550 Change-Id: I70668a02e8a610454a5713a54772144535900438 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7123009 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Simon Zünd <[email protected]> Auto-Submit: Simon Zünd <[email protected]>
1 parent 9f00325 commit 9b51dd8

File tree

8 files changed

+56
-35
lines changed

8 files changed

+56
-35
lines changed

config/gni/devtools_grd_files.gni

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -623,6 +623,7 @@ grd_files_bundled_sources = [
623623
"front_end/models/trace/trace.js",
624624
"front_end/models/trace/types/types.js",
625625
"front_end/models/trace_source_maps_resolver/trace_source_maps_resolver.js",
626+
"front_end/models/workspace/workspace-meta.js",
626627
"front_end/models/workspace/workspace.js",
627628
"front_end/models/workspace_diff/workspace_diff.js",
628629
"front_end/ndb_app.html",

front_end/core/sdk/sdk-meta.ts

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -367,41 +367,6 @@ const UIStrings = {
367367
const str_ = i18n.i18n.registerUIStrings('core/sdk/sdk-meta.ts', UIStrings);
368368
const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
369369

370-
Common.Settings.registerSettingExtension({
371-
storageType: Common.Settings.SettingStorageType.SYNCED,
372-
settingName: 'skip-stack-frames-pattern',
373-
settingType: Common.Settings.SettingType.REGEX,
374-
defaultValue: '/node_modules/|^node:',
375-
});
376-
377-
Common.Settings.registerSettingExtension({
378-
storageType: Common.Settings.SettingStorageType.SYNCED,
379-
settingName: 'skip-content-scripts',
380-
settingType: Common.Settings.SettingType.BOOLEAN,
381-
defaultValue: true,
382-
});
383-
384-
Common.Settings.registerSettingExtension({
385-
storageType: Common.Settings.SettingStorageType.SYNCED,
386-
settingName: 'automatically-ignore-list-known-third-party-scripts',
387-
settingType: Common.Settings.SettingType.BOOLEAN,
388-
defaultValue: true,
389-
});
390-
391-
Common.Settings.registerSettingExtension({
392-
storageType: Common.Settings.SettingStorageType.SYNCED,
393-
settingName: 'skip-anonymous-scripts',
394-
settingType: Common.Settings.SettingType.BOOLEAN,
395-
defaultValue: false,
396-
});
397-
398-
Common.Settings.registerSettingExtension({
399-
storageType: Common.Settings.SettingStorageType.SYNCED,
400-
settingName: 'enable-ignore-listing',
401-
settingType: Common.Settings.SettingType.BOOLEAN,
402-
defaultValue: true,
403-
});
404-
405370
Common.Settings.registerSettingExtension({
406371
category: Common.Settings.SettingCategory.CONSOLE,
407372
storageType: Common.Settings.SettingStorageType.SYNCED,

front_end/entrypoints/shell/BUILD.gn

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ devtools_entrypoint("shell") {
1515
"../../entrypoints/main:meta",
1616
"../../models/logs:meta",
1717
"../../models/persistence:meta",
18+
"../../models/workspace:meta",
1819
"../../panels/ai_assistance:meta",
1920
"../../panels/application:meta",
2021
"../../panels/changes:meta",

front_end/entrypoints/shell/shell.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import '../main/main-meta.js';
1818
import '../../ui/legacy/components/perf_ui/perf_ui-meta.js';
1919
import '../../ui/legacy/components/quick_open/quick_open-meta.js';
2020
import '../../core/sdk/sdk-meta.js';
21+
import '../../models/workspace/workspace-meta.js';
2122
import '../../ui/legacy/components/source_frame/source_frame-meta.js';
2223
import '../../panels/console_counters/console_counters-meta.js';
2324
import '../../ui/legacy/components/object_ui/object_ui-meta.js';

front_end/entrypoints/trace_app/BUILD.gn

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ devtools_entrypoint("entrypoint") {
1414
"../../entrypoints/main:meta",
1515
"../../models/logs:meta",
1616
"../../models/persistence:meta",
17+
"../../models/workspace:meta",
1718
"../../panels/ai_assistance:meta",
1819
"../../panels/browser_debugger:meta",
1920
"../../panels/developer_resources:meta",

front_end/entrypoints/trace_app/trace_app.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import '../main/main-meta.js';
66
import '../inspector_main/inspector_main-meta.js';
77
import '../../core/sdk/sdk-meta.js';
8+
import '../../models/workspace/workspace-meta.js';
89
import '../../Images/Images.js';
910
import '../../models/logs/logs-meta.js';
1011
import '../../models/persistence/persistence-meta.js';

front_end/models/workspace/BUILD.gn

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,17 @@ devtools_entrypoint("bundle") {
7474
visibility += devtools_models_visibility
7575
}
7676

77+
devtools_entrypoint("meta") {
78+
entrypoint = "workspace-meta.ts"
79+
80+
deps = [
81+
":bundle",
82+
"../../core/common:bundle",
83+
]
84+
85+
visibility = [ "../../entrypoints/*" ]
86+
}
87+
7788
ts_library("unittests") {
7889
testonly = true
7990

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
1+
// Copyright 2025 The Chromium Authors
2+
// Use of this source code is governed by a BSD-style license that can be
3+
// found in the LICENSE file.
4+
5+
import * as Common from '../../core/common/common.js';
6+
7+
Common.Settings.registerSettingExtension({
8+
storageType: Common.Settings.SettingStorageType.SYNCED,
9+
settingName: 'skip-stack-frames-pattern',
10+
settingType: Common.Settings.SettingType.REGEX,
11+
defaultValue: '/node_modules/|^node:',
12+
});
13+
14+
Common.Settings.registerSettingExtension({
15+
storageType: Common.Settings.SettingStorageType.SYNCED,
16+
settingName: 'skip-content-scripts',
17+
settingType: Common.Settings.SettingType.BOOLEAN,
18+
defaultValue: true,
19+
});
20+
21+
Common.Settings.registerSettingExtension({
22+
storageType: Common.Settings.SettingStorageType.SYNCED,
23+
settingName: 'automatically-ignore-list-known-third-party-scripts',
24+
settingType: Common.Settings.SettingType.BOOLEAN,
25+
defaultValue: true,
26+
});
27+
28+
Common.Settings.registerSettingExtension({
29+
storageType: Common.Settings.SettingStorageType.SYNCED,
30+
settingName: 'skip-anonymous-scripts',
31+
settingType: Common.Settings.SettingType.BOOLEAN,
32+
defaultValue: false,
33+
});
34+
35+
Common.Settings.registerSettingExtension({
36+
storageType: Common.Settings.SettingStorageType.SYNCED,
37+
settingName: 'enable-ignore-listing',
38+
settingType: Common.Settings.SettingType.BOOLEAN,
39+
defaultValue: true,
40+
});

0 commit comments

Comments
 (0)