Skip to content

Commit b11b91f

Browse files
Connor ClarkDevtools-frontend LUCI CQ
authored andcommitted
[RPP] Remove font-display column from insight
Also fix `.timeline-link` centering text when placed in a button. Bug: 352244504 Change-Id: Ib9cb09506eab78f4a5e358466312b01e5ad19c3e Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6221820 Reviewed-by: Paul Irish <[email protected]> Commit-Queue: Connor Clark <[email protected]>
1 parent 1823d9a commit b11b91f

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

front_end/panels/timeline/components/insights/FontDisplay.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,12 +65,11 @@ export class FontDisplay extends BaseInsightComponent<FontDisplayInsightModel> {
6565
${html`<devtools-performance-table
6666
.data=${{
6767
insight: this,
68-
headers: [i18nString(UIStrings.fontColumn), 'font-display', i18nString(UIStrings.wastedTimeColumn)],
68+
headers: [i18nString(UIStrings.fontColumn), i18nString(UIStrings.wastedTimeColumn)],
6969
rows: this.model.fonts.map(font => ({
7070
values: [
7171
// TODO(crbug.com/369422196): the font name would be nicer here.
7272
eventRef(font.request),
73-
font.display,
7473
i18n.TimeUtilities.millisToString(font.wastedTime),
7574
],
7675
overlays: [this.#overlayForRequest.get(font.request)],

front_end/panels/timeline/components/insights/baseInsightComponent.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,7 @@ ul.insight-icon-results {
205205
border: none;
206206
padding: 0;
207207
font: inherit;
208+
text-align: left;
208209
}
209210

210211
.timeline-link.invalid-link {

front_end/panels/timeline/components/layoutShiftDetails.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@
5858
border: none;
5959
padding: 0;
6060
font: inherit;
61+
text-align: left;
6162
}
6263

6364
.timeline-link.invalid-link {

0 commit comments

Comments
 (0)