Skip to content

Commit b42069a

Browse files
legendecasDevtools-frontend LUCI CQ
authored andcommitted
[node_app] Fix Node.js connection page icon
The node_app icon is broken. Fixed: 390150759 Change-Id: I4fed38e2ce09d659d95c36e6787aaa0840178f8a Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6175238 Reviewed-by: Yang Guo <[email protected]> Reviewed-by: Danil Somsikov <[email protected]> Commit-Queue: Yang Guo <[email protected]>
1 parent a9c30a5 commit b42069a

File tree

5 files changed

+7
-1
lines changed

5 files changed

+7
-1
lines changed

AUTHORS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ Yuan Zhuang <[email protected]>
9595
# END individuals section.
9696

9797
# BEGIN organizations section.
98+
Bloomberg Finance L.P. <*@bloomberg.net>
9899
Cloudflare, Inc. <*@cloudflare.com>
99100
Facebook, Inc. <*@fb.com>
100101
Google Inc. <*@google.com>

config/gni/devtools_grd_files.gni

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,7 @@ grd_files_release_sources = [
207207
"front_end/Images/navigationControls.png",
208208
"front_end/Images/navigationControls_2x.png",
209209
"front_end/Images/network-settings.svg",
210+
"front_end/Images/node-stack-icon.svg",
210211
"front_end/Images/nodeIcon.avif",
211212
"front_end/Images/open-externally.svg",
212213
"front_end/Images/override.svg",

config/gni/devtools_image_files.gni

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,7 @@ devtools_svg_sources = [
207207
"mop.svg",
208208
"mouse.svg",
209209
"network-settings.svg",
210+
"node-stack-icon.svg",
210211
"open-externally.svg",
211212
"override.svg",
212213
"palette.svg",
Lines changed: 1 addition & 0 deletions
Loading

front_end/entrypoints/node_app/NodeConnectionsPanel.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ const UIStrings = {
3737
const str_ = i18n.i18n.registerUIStrings('entrypoints/node_app/NodeConnectionsPanel.ts', UIStrings);
3838
const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
3939

40+
const nodejsIconUrl = new URL('../../Images/node-stack-icon.svg', import.meta.url).toString();
41+
4042
export class NodeConnectionsPanel extends UI.Panel.Panel {
4143
#config!: Adb.Config;
4244
readonly #networkDiscoveryView: NodeConnectionsView;
@@ -48,7 +50,7 @@ export class NodeConnectionsPanel extends UI.Panel.Panel {
4850
const container = this.contentElement.createChild('div', 'node-panel-center');
4951

5052
const image = container.createChild('img', 'node-panel-logo');
51-
image.src = 'https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg';
53+
image.src = nodejsIconUrl;
5254

5355
Host.InspectorFrontendHost.InspectorFrontendHostInstance.events.addEventListener(
5456
Host.InspectorFrontendHostAPI.Events.DevicesDiscoveryConfigChanged, this.#devicesDiscoveryConfigChanged, this);

0 commit comments

Comments
 (0)