Convert no-self-closing-custom-element-tagnames to TypeScript

Bug: chromium:397586315
Change-Id: I48e0e75009f042b29839318ba71c7b13bb5b133d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6441163
Auto-Submit: Mathias Bynens <[email protected]>
Reviewed-by: Nikolay Vitkov <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>

Author: mathiasbynens

scripts/eslint_rules/lib/no-self-closing-custom-element-tagnames.js renamed to scripts/eslint_rules/lib/no-self-closing-custom-element-tagnames.ts

@@ -1,23 +1,25 @@
 // Copyright 2021 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-'use strict';
 
-const {isLitHtmlTemplateCall} = require('./utils.js');
+import {createRule} from './tsUtils.ts';
+import {isLitHtmlTemplateCall} from './utils.js';
 
-/**
- * @type {import('eslint').Rule.RuleModule}
- */
-module.exports = {
+export default createRule({
+  name: 'no-self-closing-custom-element-tagnames',
   meta: {
     type: 'problem',
     docs: {
       description: 'Check for self closing custom element tag names in Lit templates.',
       category: 'Possible Errors',
     },
+    messages: {
+      requiredEndTag: 'Custom elements should not be self-closing.',
+    },
     fixable: 'code',
     schema: []  // no options
   },
+  defaultOptions: [],
   create: function(context) {
     return {
       TaggedTemplateExpression(node) {
@@ -31,10 +33,10 @@ module.exports = {
         if (text.match(/<@TEMPLATE_EXPRESSION\(\)([^>]*?)\/>/)) {
           context.report({
             node,
-            message: 'Custom elements should not be self closing.',
+            messageId: 'requiredEndTag',
           });
         }
       },
     };
   }
-};
+});

scripts/eslint_rules/tests/no-self-closing-custom-element-tagnames.test.js renamed to scripts/eslint_rules/tests/no-self-closing-custom-element-tagnames.test.ts

@@ -1,12 +1,10 @@
 // Copyright 2021 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-'use strict';
-const rule = require('../lib/no-self-closing-custom-element-tagnames.js');
 
-const {RuleTester} = require('./utils/utils.js');
+import rule from '../lib/no-self-closing-custom-element-tagnames.ts';
 
-const EXPECTED_ERROR_MESSAGE = 'Custom elements should not be self closing.';
+import {RuleTester} from './utils/tsUtils.ts';
 
 new RuleTester().run('no-self-closing-custom-element-tagnames', rule, {
   valid: [
@@ -40,22 +38,22 @@ new RuleTester().run('no-self-closing-custom-element-tagnames', rule, {
     {
       code: 'Lit.html`<${DataGrid.litTagName} />`',
       filename: 'front_end/components/test.ts',
-      errors: [{message: EXPECTED_ERROR_MESSAGE}],
+      errors: [{messageId: 'requiredEndTag'}],
     },
     {
       code: 'Lit.html`<p><${DataGrid.litTagName} /></p>`',
       filename: 'front_end/components/test.ts',
-      errors: [{message: EXPECTED_ERROR_MESSAGE}],
+      errors: [{messageId: 'requiredEndTag'}],
     },
     {
       code: 'Lit.html`<${DataGrid1.litTagName}><${DataGrid2.litTagName} /></${DataGrid1.litTagName}>`',
       filename: 'front_end/components/test.ts',
-      errors: [{message: EXPECTED_ERROR_MESSAGE}],
+      errors: [{messageId: 'requiredEndTag'}],
     },
     {
       code: 'Lit.html`<${DataGrid.litTagName} .data=${{test: "Hello World"}}/>`',
       filename: 'front_end/components/test.ts',
-      errors: [{message: EXPECTED_ERROR_MESSAGE}],
+      errors: [{messageId: 'requiredEndTag'}],
     },
   ],
 });