[RPP] Add estimated byte savings to Duplicated JavaScript insight

Also fix #shouldShowTreemap

Bug: 394373632
Change-Id: Ia34504bfa8a99c6c5d5d12212ddcae463490b0dd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6404285
Reviewed-by: Paul Irish <[email protected]>
Auto-Submit: Connor Clark <[email protected]>
Commit-Queue: Connor Clark <[email protected]>

Author: Connor Clark

front_end/panels/timeline/components/insights/DuplicatedJavaScript.ts

@@ -31,7 +31,7 @@ export class DuplicatedJavaScript extends BaseInsightComponent<DuplicateJavaScri
       return false;
     }
 
-    return this.model.scripts.length > 0;
+    return this.model.scripts.some(script => !!script.url);
   }
 
   #openTreemap(): void {
@@ -51,6 +51,19 @@ export class DuplicatedJavaScript extends BaseInsightComponent<DuplicateJavaScri
     return this.model?.metricSavings?.FCP ?? null;
   }
 
+  override getEstimatedSavingsBytes(): number|null {
+    if (!this.model) {
+      return null;
+    }
+
+    let totalDuplicatedBytes = 0;
+    for (const data of this.model.duplicationGroupedByNodeModules.values()) {
+      totalDuplicatedBytes += data.estimatedDuplicateBytes;
+    }
+
+    return totalDuplicatedBytes;
+  }
+
   override createOverlays(): Overlays.Overlays.TimelineOverlay[] {
     if (!this.model) {
       return [];