Skip to content

Commit ddcbcdd

Browse files
ktranDevtools-frontend LUCI CQ
authored andcommitted
[FieldSettings] Fix field settings dialog paddings
Before: blob:https://imgur.com/187d3cf2-2d0f-49a5-8349-95daea2ceece After: https://i.imgur.com/k04Vmy8.png Bug: 383278166 Change-Id: I206480352dcc8bd7ef098404e92b64ab51eabb2e Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6108798 Reviewed-by: Nancy Li <[email protected]> Commit-Queue: Nancy Li <[email protected]> Auto-Submit: Kim-Anh Tran <[email protected]>
1 parent df8bada commit ddcbcdd

File tree

2 files changed

+3
-10
lines changed

2 files changed

+3
-10
lines changed

front_end/panels/timeline/components/FieldSettingsDialog.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -342,12 +342,12 @@ export class FieldSettingsDialog extends HTMLElement {
342342
.position=${Dialogs.Dialog.DialogVerticalPosition.AUTO}
343343
.horizontalAlignment=${Dialogs.Dialog.DialogHorizontalAlignment.CENTER}
344344
.jslogContext=${'timeline.field-data.settings'}
345+
.dialogTitle=${i18nString(UIStrings.configureFieldData)}
345346
on-render=${ComponentHelpers.Directives.nodeRenderedCallback(node => {
346347
this.#dialog = node as Dialogs.Dialog.Dialog;
347348
})}
348349
>
349350
<div class="content">
350-
<h2 class="title">${i18nString(UIStrings.configureFieldData)}</h2>
351351
<div>${descriptionEl}</div>
352352
<div class="privacy-disclosure">
353353
<h3 class="section-title">${i18nString(UIStrings.privacyDisclosure)}</h3>

front_end/panels/timeline/components/fieldSettingsDialog.css

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,6 @@ devtools-dialog {
1616
--override-transparent: color-mix(in sRGB, var(--color-background) 80%, transparent);
1717
}
1818

19-
.title {
20-
font-size: var(--sys-typescale-headline4-size);
21-
line-height: var(--sys-typescale-headline4-line-height);
22-
font-weight: var(--ref-typeface-weight-medium);
23-
margin: 0;
24-
}
25-
2619
.section-title {
2720
font-size: var(--sys-typescale-headline5-size);
2821
line-height: var(--sys-typescale-headline5-line-height);
@@ -51,7 +44,7 @@ details > summary {
5144

5245
.content {
5346
max-width: 360px;
54-
padding: 16px 4px 18px;
47+
padding: 0 var(--sys-size-8) var(--sys-size-2);
5548
box-sizing: border-box;
5649
}
5750

@@ -73,7 +66,7 @@ details > summary {
7366
display: flex;
7467
flex-direction: column;
7568
align-items: center;
76-
margin-top: 6px;
69+
margin-top: var(--sys-size-6);
7770
}
7871

7972
.config-button {

0 commit comments

Comments
 (0)