[cleanup] Remove unused params

Bug: 409278895
Change-Id: Ie08adb5c3b5574fc013fc6ba75675b2a23367529
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6439509
Auto-Submit: Nikolay Vitkov <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>

Author: Lightning00Blade

front_end/core/sdk/CPUProfilerModel.ts

@@ -51,8 +51,7 @@ export class CPUProfilerModel extends SDKModel<EventTypes> implements ProtocolPr
   #nextAnonymousConsoleProfileNumber: number;
   #anonymousConsoleProfileIdToTitle: Map<string, string>;
   readonly #profilerAgent: ProtocolProxyApi.ProfilerApi;
-  #preciseCoverageDeltaUpdateCallback:
-      ((arg0: number, arg1: string, arg2: Protocol.Profiler.ScriptCoverage[]) => Promise<void>)|null;
+  #preciseCoverageDeltaUpdateCallback: ((arg0: number, arg2: Protocol.Profiler.ScriptCoverage[]) => Promise<void>)|null;
   readonly #debuggerModelInternal: DebuggerModel;
   readonly registeredConsoleProfileMessages: ProfileFinishedData[] = [];
 
@@ -120,8 +119,7 @@ export class CPUProfilerModel extends SDKModel<EventTypes> implements ProtocolPr
 
   startPreciseCoverage(
       jsCoveragePerBlock: boolean,
-      preciseCoverageDeltaUpdateCallback:
-          ((arg0: number, arg1: string, arg2: Protocol.Profiler.ScriptCoverage[]) => Promise<void>)|
+      preciseCoverageDeltaUpdateCallback: ((arg0: number, arg2: Protocol.Profiler.ScriptCoverage[]) => Promise<void>)|
       null): Promise<unknown> {
     const callCount = false;
     this.#preciseCoverageDeltaUpdateCallback = preciseCoverageDeltaUpdateCallback;
@@ -145,9 +143,9 @@ export class CPUProfilerModel extends SDKModel<EventTypes> implements ProtocolPr
     return this.#profilerAgent.invoke_stopPreciseCoverage();
   }
 
-  preciseCoverageDeltaUpdate({timestamp, occasion, result}: Protocol.Profiler.PreciseCoverageDeltaUpdateEvent): void {
+  preciseCoverageDeltaUpdate({timestamp, result}: Protocol.Profiler.PreciseCoverageDeltaUpdateEvent): void {
     if (this.#preciseCoverageDeltaUpdateCallback) {
-      void this.#preciseCoverageDeltaUpdateCallback(timestamp, occasion, result);
+      void this.#preciseCoverageDeltaUpdateCallback(timestamp, result);
     }
   }
 }

front_end/entrypoints/node_app/NodeConnectionsPanel.ts

@@ -145,7 +145,7 @@ export class NodeConnectionsView extends UI.Widget.VBox implements UI.ListWidget
     return element;
   }
 
-  removeItemRequested(rule: Adb.PortForwardingRule, index: number): void {
+  removeItemRequested(_rule: Adb.PortForwardingRule, index: number): void {
     this.#networkDiscoveryConfig.splice(index, 1);
     this.#list.removeItem(index);
     this.#update();

front_end/models/breakpoints/BreakpointManager.ts

@@ -472,7 +472,7 @@ export class BreakpointManager extends Common.ObjectWrapper.ObjectWrapper<EventT
     this.dispatchEventToListeners(Events.BreakpointAdded, breakpointLocation);
   }
 
-  uiLocationRemoved(breakpoint: Breakpoint, uiLocation: Workspace.UISourceCode.UILocation): void {
+  uiLocationRemoved(uiLocation: Workspace.UISourceCode.UILocation): void {
     const breakpoints = this.#breakpointsForUISourceCode.get(uiLocation.uiSourceCode);
     if (!breakpoints) {
       return;
@@ -707,7 +707,7 @@ export class Breakpoint implements SDK.TargetManager.SDKModelObserver<SDK.Debugg
       this.uiSourceCodes.delete(uiSourceCode);
       this.breakpointManager.removeHomeUISourceCode(uiSourceCode, this);
       if (!this.bound()) {
-        this.breakpointManager.uiLocationRemoved(this, this.defaultUILocation(uiSourceCode));
+        this.breakpointManager.uiLocationRemoved(this.defaultUILocation(uiSourceCode));
       }
     }
 
@@ -716,7 +716,7 @@ export class Breakpoint implements SDK.TargetManager.SDKModelObserver<SDK.Debugg
       for (const uiLocation of this.#uiLocations) {
         if (uiLocation.uiSourceCode === uiSourceCode) {
           this.#uiLocations.delete(uiLocation);
-          this.breakpointManager.uiLocationRemoved(this, uiLocation);
+          this.breakpointManager.uiLocationRemoved(uiLocation);
         }
       }
 
@@ -754,7 +754,7 @@ export class Breakpoint implements SDK.TargetManager.SDKModelObserver<SDK.Debugg
   uiLocationRemoved(uiLocation: Workspace.UISourceCode.UILocation): void {
     if (this.#uiLocations.has(uiLocation)) {
       this.#uiLocations.delete(uiLocation);
-      this.breakpointManager.uiLocationRemoved(this, uiLocation);
+      this.breakpointManager.uiLocationRemoved(uiLocation);
       if (!this.bound() && !this.isRemoved) {
         this.addAllUnboundLocations();
       }
@@ -878,7 +878,7 @@ export class Breakpoint implements SDK.TargetManager.SDKModelObserver<SDK.Debugg
 
   private removeAllUnboundLocations(): void {
     for (const uiSourceCode of this.uiSourceCodes) {
-      this.breakpointManager.uiLocationRemoved(this, this.defaultUILocation(uiSourceCode));
+      this.breakpointManager.uiLocationRemoved(this.defaultUILocation(uiSourceCode));
     }
   }
 

front_end/models/extensions/ExtensionAPI.ts

@@ -682,7 +682,7 @@ self.injectedExtensionAPI = function(
   (Panels.prototype as
    Pick<APIImpl.Panels, 'create'|'setOpenResourceHandler'|'openResource'|'SearchAction'|'setThemeChangeHandler'>) = {
     create: function(
-        title: string, icon: string, page: string,
+        title: string, _icon: string, page: string,
         callback: (panel: PublicAPI.Chrome.DevTools.ExtensionPanel) => unknown): void {
       const id = 'extension-panel-' + extensionServer.nextObjectId();
       extensionServer.sendRequest(

front_end/models/trace/TracingManager.test.ts

@@ -55,7 +55,7 @@ describeWithMockConnection('TracingManager', () => {
     const eventsCollectedSpy = sinon.spy(client, 'traceEventsCollected');
 
     await manager.start(client, 'devtools-timeline');
-    manager.bufferUsage(0, 0);
+    manager.bufferUsage(0);
 
     manager.eventsCollected(fakeEvents);
     assert.isTrue(eventsCollectedSpy.calledWith(fakeEvents));
@@ -68,7 +68,7 @@ describeWithMockConnection('TracingManager', () => {
     const client = new FakeClient();
     const tracingCompleteSpy = sinon.spy(client, 'tracingComplete');
     await manager.start(client, 'devtools-timeline');
-    manager.bufferUsage(0, 0);
+    manager.bufferUsage(0);
     manager.eventsCollected(fakeEvents);
     manager.tracingComplete();
     assert.isTrue(tracingCompleteSpy.calledOnce);

front_end/models/trace/TracingManager.ts

@@ -22,7 +22,7 @@ export class TracingManager extends SDK.SDKModel.SDKModel<void> {
     this.#eventsRetrieved = 0;
   }
 
-  bufferUsage(usage?: number, eventCount?: number, percentFull?: number): void {
+  bufferUsage(usage?: number, percentFull?: number): void {
     if (this.#activeClient) {
       this.#activeClient.tracingBufferUsage(usage || percentFull || 0);
     }
@@ -116,8 +116,8 @@ class TracingDispatcher implements ProtocolProxyApi.TracingDispatcher {
   }
 
   // `eventCount` will always be 0 as perfetto no longer calculates `approximate_event_count`
-  bufferUsage({value, eventCount, percentFull}: Protocol.Tracing.BufferUsageEvent): void {
-    this.#tracingManager.bufferUsage(value, eventCount, percentFull);
+  bufferUsage({value, percentFull}: Protocol.Tracing.BufferUsageEvent): void {
+    this.#tracingManager.bufferUsage(value, percentFull);
   }
 
   dataCollected({value}: Protocol.Tracing.DataCollectedEvent): void {

front_end/models/trace/handlers/RendererHandler.ts

@@ -172,7 +172,7 @@ export function assignMeta(
     threadsInProcess: Map<Types.Events.ProcessID, Map<Types.Events.ThreadID, Types.Events.ThreadName>>): void {
   assignOrigin(processes, rendererProcessesByFrame);
   assignIsMainFrame(processes, mainFrameId, rendererProcessesByFrame);
-  assignThreadName(processes, rendererProcessesByFrame, threadsInProcess);
+  assignThreadName(processes, threadsInProcess);
 }
 
 /**
@@ -233,7 +233,7 @@ export function assignIsMainFrame(
  * @see assignMeta
  */
 export function assignThreadName(
-    processes: Map<Types.Events.ProcessID, RendererProcess>, rendererProcessesByFrame: FrameProcessData,
+    processes: Map<Types.Events.ProcessID, RendererProcess>,
     threadsInProcess: Map<Types.Events.ProcessID, Map<Types.Events.ThreadID, Types.Events.ThreadName>>): void {
   for (const [pid, process] of processes) {
     for (const [tid, threadInfo] of threadsInProcess.get(pid) ?? []) {

front_end/panels/browser_debugger/DOMBreakpointsSidebarPane.ts

@@ -273,7 +273,7 @@ export class DOMBreakpointsSidebarPane extends UI.Widget.VBox implements
   }
 
   selectedItemChanged(
-      from: SDK.DOMDebuggerModel.DOMBreakpoint|null, to: SDK.DOMDebuggerModel.DOMBreakpoint|null,
+      _from: SDK.DOMDebuggerModel.DOMBreakpoint|null, _to: SDK.DOMDebuggerModel.DOMBreakpoint|null,
       fromElement: HTMLElement|null, toElement: HTMLElement|null): void {
     if (fromElement) {
       fromElement.tabIndex = -1;
@@ -406,7 +406,7 @@ const BreakpointTypeLabels = new Map([
 ]);
 
 export class ContextMenuProvider implements UI.ContextMenu.Provider<SDK.DOMModel.DOMNode> {
-  appendApplicableItems(event: Event, contextMenu: UI.ContextMenu.ContextMenu, node: SDK.DOMModel.DOMNode): void {
+  appendApplicableItems(_event: Event, contextMenu: UI.ContextMenu.ContextMenu, node: SDK.DOMModel.DOMNode): void {
     if (node.pseudoType()) {
       return;
     }

front_end/panels/browser_debugger/XHRBreakpointsSidebarPane.ts

@@ -241,7 +241,7 @@ export class XHRBreakpointsSidebarPane extends UI.Widget.VBox implements UI.Cont
     return listItemElement;
   }
 
-  selectedItemChanged(from: string|null, to: string|null, fromElement: HTMLElement|null, toElement: HTMLElement|null):
+  selectedItemChanged(_from: string|null, _to: string|null, fromElement: HTMLElement|null, toElement: HTMLElement|null):
       void {
     if (fromElement) {
       const breakpointEntryElement = containerToBreakpointEntry.get(fromElement);

front_end/panels/console/ConsoleContextSelector.ts

@@ -74,7 +74,7 @@ export class ConsoleContextSelector implements SDK.TargetManager.SDKModelObserve
   }
 
   highlightedItemChanged(
-      from: SDK.RuntimeModel.ExecutionContext|null, to: SDK.RuntimeModel.ExecutionContext|null,
+      _from: SDK.RuntimeModel.ExecutionContext|null, to: SDK.RuntimeModel.ExecutionContext|null,
       fromElement: Element|null, toElement: Element|null): void {
     SDK.OverlayModel.OverlayModel.hideDOMNodeHighlight();
     if (to && to.frameId) {