Skip to content

Commit f2a029f

Browse files
Adriana IxbaDevtools-frontend LUCI CQ
authored andcommitted
[RPP] More than 2 marker events a the same ts fail
This fixes a small bug where if we have more than 2, rendering the trace breaks. Bug:None Change-Id: I8105c126f401f5a7e803c9891bafe08372423e48 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6052257 Commit-Queue: Adriana Ixba <[email protected]> Reviewed-by: Adam Raine <[email protected]>
1 parent eadd2d5 commit f2a029f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

front_end/panels/timeline/TimelineFlameChartView.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -471,8 +471,8 @@ export class TimelineFlameChartView extends
471471
parsedTrace.Meta.navigationsByFrameId,
472472
);
473473
// If any of the markers overlap in timing, lets put them on the same marker.
474-
if (i > 0 && ts === markerOverlays[i - 1].adjustedTimestamp) {
475-
markerOverlays[i - 1].entries.push(marker);
474+
if (i > 0 && ts === markerOverlays[markerOverlays.length - 1].adjustedTimestamp) {
475+
markerOverlays[markerOverlays.length - 1].entries.push(marker);
476476
return;
477477
}
478478
const overlay = {

0 commit comments

Comments
 (0)