Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some options and logging to analyze performance problems reported in #326.
In theory, "spawn" should be used to call PMD, avoiding the buffering problem. Switching to this by default would make the config option
commandBufferSizeunnecessary.A simple counter can prevent PMD processes from piling up. Maybe we should cancel the old one and start a new one?
New config options:
limitPMDProcesses: enabled by default. new behavior - this could serve as a hotfix, but doesn't address the unknown root cause.childProcessMethod: by default "exec". Can be changed to "execFile" and "spawn" to test, which one is "faster".