Skip to content

Refactor duplicate error handling into fetchErrorMessage helper #7644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DawoudIO merged 3 commits into from
Nov 26, 2025
Merged

Refactor duplicate error handling into fetchErrorMessage helper #7644

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52ee411
Initial plan
Copilot Nov 26, 2025
968a12a
Refactor: Extract duplicate error handling into fetchErrorMessage helper
Copilot Nov 26, 2025
6df7f15
Merge branch 'master' into copilot/sub-pr-7642
DawoudIO Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 28 additions & 36 deletions src/skin/js/CRMJSOM.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,28 @@ window.CRM.VerifyThenLoadAPIContent = function (url) {
var error = i18next.t(
"There was a problem retrieving the requested object",
);

// Helper function to fetch error message from JSON response
function fetchErrorMessage(targetUrl, fallbackError, callback) {
try {
$.ajax({
method: "GET",
url: targetUrl,
async: false,
dataType: "json",
success: function (data) {
var msg = data && data.message ? data.message : fallbackError;
callback(msg);
},
error: function () {
callback(fallbackError);
},
});
} catch (e) {
callback(fallbackError);
}
}

$.ajax({
method: "HEAD",
url: url,
Expand All @@ -62,44 +84,14 @@ window.CRM.VerifyThenLoadAPIContent = function (url) {
window.open(url);
},
404: function () {
// Try to fetch the body to get a more helpful message (the route may return JSON)
try {
$.ajax({
method: "GET",
url: url,
async: false,
dataType: "json",
success: function (data) {
var msg = data && data.message ? data.message : error;
window.CRM.DisplayErrorMessage(url, { message: msg });
},
error: function () {
window.CRM.DisplayErrorMessage(url, { message: error });
},
});
} catch (e) {
window.CRM.DisplayErrorMessage(url, { message: error });
}
fetchErrorMessage(url, error, function (msg) {
window.CRM.DisplayErrorMessage(url, { message: msg });
});
},
500: function () {
// For 500, try to fetch JSON body for a clearer message
try {
$.ajax({
method: "GET",
url: url,
async: false,
dataType: "json",
success: function (data) {
var msg = data && data.message ? data.message : error;
window.CRM.DisplayErrorMessage(url, { message: msg });
},
error: function () {
window.CRM.DisplayErrorMessage(url, { message: error });
},
});
} catch (e) {
window.CRM.DisplayErrorMessage(url, { message: error });
}
fetchErrorMessage(url, error, function (msg) {
window.CRM.DisplayErrorMessage(url, { message: msg });
});
},
},
});
Expand Down