Fix SQL injection in EditEventAttendees and improve UX#7665
Closed
Fix SQL injection in EditEventAttendees and improve UX#7665
Conversation
- Fix CVE-2025-1133: Replace raw SQL DELETE with Propel ORM parameterized query - Sanitize all POST/GET inputs using InputUtils::legacyFilterInputArr() - Add EventAttendQuery import for type-safe database operations - Add 'Check In People' navigation button linking to event check-in form - Improve table styling with Bootstrap classes (table-sm table-striped) - Add proper null checks and type casting for database values - Prevent SQL injection vulnerabilities in event attendee deletion"
DawoudIO
requested review from
DAcodedBEAT,
MrClever,
bigtigerku,
grayeul and
respencer
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes CVE-2025-1133, a SQL injection vulnerability in the event attendee deletion functionality. The changes replace raw SQL queries with Propel ORM parameterized queries and improve input sanitization throughout the file. Additionally, UX enhancements include a new "Check In People" navigation button and improved table styling.
Key Changes:
- Replaced vulnerable raw SQL DELETE with Propel ORM
EventAttendQueryfor safe, parameterized deletion - Migrated all input handling from direct
$_POST/$_GETaccess toInputUtils::legacyFilterInputArr() - Converted attendee listing from raw SQL to Propel ORM with proper joins and relationships
Comment on lines
+96
to
+100
| $sHomePhone = SelectWhichInfo( | ||
| ExpandPhoneNumber($person->getPerHomephone(), $sPhoneCountry, $dummy), | ||
| ExpandPhoneNumber($family ? $family->getFamHomePhone() : null, $famCountry, $dummy), | ||
| true | ||
| ); |
There was a problem hiding this comment.
Variable $dummy is used but never defined, passed as a reference parameter to ExpandPhoneNumber. This will cause a PHP warning about undefined variables.
Define the variable before use:
$dummy = '';
$sPhoneCountry = SelectWhichInfo($person->getPerCountry(), $famCountry, false);
$sHomePhone = SelectWhichInfo(
ExpandPhoneNumber($person->getPerHomephone(), $sPhoneCountry, $dummy),
ExpandPhoneNumber($family ? $family->getFamHomePhone() : null, $famCountry, $dummy),
true
);
Contributor
Author
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
16 tasks
Contributor
Contributor
Author
|
I'm going to kill this page so no need for this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Fix #7252
Type
Testing
Screenshots
Security Check
Code Quality
Pre-Merge