Fix SQL injection vulnerability in WhichType parameter#7691
Merged
Conversation
Use InputUtils::filterInt() instead of legacyFilterInput() to properly sanitize the WhichType POST parameter. This ensures only integer values are accepted when filtering events by type, preventing SQL injection attacks in the event listing page.
DawoudIO
requested review from
DAcodedBEAT,
MrClever,
bigtigerku,
grayeul and
respencer
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This security-focused PR fixes a SQL injection vulnerability in the event listing page by replacing InputUtils::legacyFilterInput() with InputUtils::filterInt() for the WhichType parameter. The change ensures only integer values are accepted when filtering events by type, preventing potential SQL injection attacks.
Key Changes
- Switched from
legacyFilterInput()tofilterInt()for sanitizing theWhichTypePOST parameter - Added an explicit check for the 'All' value to handle the special case where no type filter is applied
- Maintains backward compatibility by preserving the 'All' type option behavior
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Use InputUtils::filterInt() instead of legacyFilterInput() to properly sanitize the WhichType POST parameter. This ensures only integer values are accepted when filtering events by type, preventing SQL injection attacks in the event listing page.
Type
Testing
Screenshots
Security Check
Code Quality
Pre-Merge