Merged
Conversation
- Remove extra closing </div> tag in dashboard.php (invalid HTML) - Fix i18n pluralization for anniversary badges (singular/plural day/days)
…hurchCRM/CRM into feature/dashboard-improvements
DawoudIO
requested review from
DAcodedBEAT,
MrClever,
bigtigerku,
grayeul and
respencer
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR contains quality-of-life improvements to the dashboard, including an HTML structure fix, better internationalization support for singular/plural day handling, and improved code documentation for security.
- Fixed duplicate closing div tag in dashboard template
- Improved i18n handling to correctly display "1 day" vs "2 days" for anniversary badges
- Added security documentation comment explaining SQL injection protection
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/v2/templates/root/dashboard.php |
Removed duplicate closing </div> tag that was causing invalid HTML structure |
src/skin/js/MainDashboard.js |
Improved singular/plural i18n handling for anniversary day counts, splitting "days ago" into separate "day/days" + "ago" translation keys for better language support |
src/api/routes/people/people-families.php |
Added security comment documenting that date values are safe from SQL injection due to integer casting, plus minor whitespace cleanup |
Comments suppressed due to low confidence (1)
src/skin/js/MainDashboard.js:422
- Unused function buildRenderEmail.
function buildRenderEmail(email) {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Fixes #
Type
Testing
Screenshots
Security Check
Code Quality
Pre-Merge