fix: address review issues in FrankenPHP Docker support (#8213)#8221
Conversation
- Use mv instead of cp for php.ini-production to avoid leaving unused template in the image layer (matches Dockerfile.churchcrm-fpm-php8) - Fix README heading style: setext --- to ATX ### for consistency - Add missing newline at EOF in README.md Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Follow-up adjustments to the FrankenPHP Docker support added in #8213, aiming to align the Docker image layering and Docker documentation formatting with existing patterns in the repo.
Changes:
- Switch
php.ini-productionsetup in the FrankenPHP Dockerfile fromcptomvto avoid leaving the template in the image layer. - Update the FrankenPHP section heading in
docker/README.mdand ensure the file ends with a newline.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
docker/README.md |
Adjusts FrankenPHP section heading formatting and fixes EOF newline. |
docker/Dockerfile.churchcrm-frankenphp |
Uses mv for php.ini-production → php.ini to reduce leftover artifacts in the image layer. |
|
|
||
| Self-Hosted / Production (FrankenPHP) | ||
| --- | ||
| ### Self-Hosted / Production (FrankenPHP) |
There was a problem hiding this comment.
The FrankenPHP section heading was changed from a setext-style H2 to an ATX H3 ("###"), which breaks the document hierarchy: the subsequent "### Why FrankenPHP..." and "### Quick start" headings are now the same level instead of being nested under the FrankenPHP section. Consider making this heading an H2 (e.g., setext like the nginx section, or use "##") so the subheadings remain properly nested.
| ### Self-Hosted / Production (FrankenPHP) | |
| ## Self-Hosted / Production (FrankenPHP) |
68f61d3
into
copilot/test-churchcrm-with-frankenphp
Follow-up fixes for #8213 based on code review.
Changes
Dockerfile.churchcrm-frankenphp: Usemvinstead ofcpforphp.ini-production— avoids leaving the unused template in the image layer, consistent withDockerfile.churchcrm-fpm-php8docker/README.md: Convert setext---heading to ATX###style for consistency with the rest of the filedocker/README.md: Add missing newline at end of fileTest plan
docker build -f Dockerfile.churchcrm-frankenphp --target prod .succeedsphp.ini-productionis absent andphp.iniis present in the built image🤖 Generated with Claude Code