feat(sort): add Expansion sort option for items#890
Merged
Conversation
Add a new "Expansion" sort option to the Item Order dropdown, allowing users to sort items chronologically by the expansion they were introduced in (Classic -> TBC -> ... -> Midnight). Changes: - core/constants.lua:273: Add EXPANSION = 4 to ITEM_SORT_TYPE enum - config/config.lua:220-228: Add "Expansion" option to Item Order dropdown for both Backpack and Bank, mapping to const.ITEM_SORT_TYPE.EXPANSION - util/sort.lua:220-242: Implement SortItemsByExpansion function that: * Uses data.itemInfo.expacID for expansion ordering * Defaults to 0 (Classic) for items with missing expacID * Falls back to alphabetical sort when expansions are equal * Falls back to item count and GUID for stable sorting - util/sort.lua:61-76: Update GetItemSortFunction to return SortItemsByExpansion when EXPANSION sort type is selected The expansion ID is already populated by the WoW API via C_Item.GetItemInfo() and stored in itemInfo.expacID. Lower expansion IDs represent older content (0 = Classic, 11 = Midnight), providing chronological ordering. All luacheck validation passes with no warnings or errors. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new Expansion sort option to the Item Order dropdown for Backpack and Bank. Items are sorted chronologically by expansion from Classic to Midnight, with alphabetical fallback for items within the same expansion.