Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "lambda-essentials-ts",
"version": "7.0.0-beta",
"version": "7.0.1",
"description": "A selection of the finest modules supporting authorization, API routing, error handling, logging and sending HTTP requests.",
"main": "lib/index.js",
"private": false,
Expand Down
2 changes: 2 additions & 0 deletions src/tokenProvider/tokenProvider.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import jwtManager from 'jsonwebtoken';
import { AxiosRequestConfig, AxiosResponse } from 'axios';
import HttpClient from '../httpClient/httpClient';
import Logger from '../logger/logger';

export default abstract class TokenProvider {
private httpClient: TokenProviderHttpClient;
Expand All @@ -16,6 +17,7 @@ export default abstract class TokenProvider {
this.httpClient =
options.httpClient ??
new HttpClient({
logFunction: (msg) => new Logger().log(msg),
enableCache: false,
enableRetry: true,
retryOptions: {
Expand Down
26 changes: 26 additions & 0 deletions tests/logger/logger.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,32 @@ describe('log message', () => {
expect(logFunction).toHaveBeenCalledWith(JSON.stringify(receivedObject, null, 2));
});

test('test redacting secret from our http client', () => {
const logObjectWithSecret: SuggestedLogObject = {
title: 'One secret',
level: 'DEBUG',
request: {
client_id: 'baconClientId',
client_secret: 'E5BuCZ8AuBpnDfB25dhgftyuvBcBwDiBBCC5DjBGBeBfjD5BeBqhBFBQDGDp_gSw_',
audience: 'https://api.banana.io/',
grant_type: 'client_credentials',
},
};
testLogger.log(logObjectWithSecret);
const receivedObject: SuggestedLogObject = {
invocationId: 'none',
title: 'One secret',
level: 'DEBUG',
request: {
client_id: 'baconClientId',
client_secret: '<REDACTED>',
audience: 'https://api.banana.io/',
grant_type: 'client_credentials',
},
};
expect(logFunction).toHaveBeenCalledWith(JSON.stringify(receivedObject, null, 2));
});

test('test truncating TOKEN', () => {
const logObjectWithToken: SuggestedLogObject = {
title: 'One TOKEN',
Expand Down