Skip to content

Conversation

@ioreilly
Copy link

@ioreilly ioreilly commented Dec 27, 2025

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Internal Checklist

  • I am requesting a review from my own team as well as the owning team
  • [-] I have a plan in place for the monitoring of the changes that I am making (this can include new monitors, logs to be aware of, etc...)
    • I have no capability to do this as a community contributor but don't think it's relevant here.

Changes

=======

  • Add support for missing pipeline parameters

    • pipeline.trigger.received_at
    • pipeline.trigger_source
    • pipeline.schedule.name
    • pipeline.schedule.id
    • pipeline.trigger_parameters.circleci.trigger_type
    • pipeline.trigger_parameters.circleci.event_type
    • pipeline.event.context.github.pr_url
  • Update tests

Rationale

=========

There are a number of officially documented pipeline parameters that correctly resolve on compilation but are not supported in the CLI config schema validation.

As an enterprise customer who has a large GitHub Oauth org, I am trying to migrate net new usage to GitHub App and take advantage of those capabilities. It is that much harder to drive adoption when the schema is misaligned here.

As a product consideration and as customer feedback, we might want to make support here part of the GA criteria and not document them until that is done.

I appreciate your time and consideration here!

I assume this resolves #1060

Considerations

==============

  • Supplied default values where it made sense in accordance with existing conventions (e.g. ISO 8601 timestamp)
  • pipeline.trigger_parameters.circleci.event_time is still missing but obviously not desirable due to being deprecated

Screenshots

============

Integration

Before

image

After

image

Here are some helpful tips you can follow when submitting a pull request:

  1. Fork the repository and create your branch from main.
  2. Run make build in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (make test).
  5. The --debug flag is often helpful for debugging HTTP client requests and responses.
  6. Format your code with gofmt.
  7. Make sure your code lints (make lint). Note: This requires Docker to run inside a local job.

Note

Expands supported pipeline variables used during local config validation.

  • Adds pipeline.trigger.received_at, pipeline.trigger_source, pipeline.schedule.name, pipeline.schedule.id, pipeline.trigger_parameters.circleci.trigger_type, pipeline.trigger_parameters.circleci.event_type, and pipeline.event.context.github.pr_url to LocalPipelineValues
  • Notes deprecation on pipeline.trigger_parameters.circleci.event_time in favor of pipeline.trigger.received_at
  • Updates tests to assert presence of new keys

Written by Cursor Bugbot for commit 6324cd7. This will update automatically on new commits. Configure here.

@ioreilly ioreilly requested a review from a team as a code owner December 27, 2025 15:58
@ioreilly ioreilly force-pushed the fix/missing-github-app-pipeline-parameters branch from 2575f55 to 6324cd7 Compare December 27, 2025 16:06
@ioreilly
Copy link
Author

The failing cucumber scenario does not appear to be documented anywhere, but also does not look like an actionable error for a community contributor or relevant to this PR. Happy to correct that if not the case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validation fails for github/gitlab trigger_parameters

1 participant