fix(config/pipeline): support missing pipeline parameters for config validation #1172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
=========
Internal Checklist
Changes
=======
Add support for missing pipeline parameters
pipeline.trigger.received_atpipeline.trigger_sourcepipeline.schedule.namepipeline.schedule.idpipeline.trigger_parameters.circleci.trigger_typepipeline.trigger_parameters.circleci.event_typepipeline.event.context.github.pr_urlUpdate tests
Rationale
=========
There are a number of officially documented pipeline parameters that correctly resolve on compilation but are not supported in the CLI config schema validation.
As an enterprise customer who has a large GitHub Oauth org, I am trying to migrate net new usage to GitHub App and take advantage of those capabilities. It is that much harder to drive adoption when the schema is misaligned here.
As a product consideration and as customer feedback, we might want to make support here part of the GA criteria and not document them until that is done.
I appreciate your time and consideration here!
I assume this resolves #1060
Considerations
==============
pipeline.trigger_parameters.circleci.event_timeis still missing but obviously not desirable due to being deprecatedScreenshots
============
Integration
Before
After
Here are some helpful tips you can follow when submitting a pull request:
main.make buildin the repository root.make test).--debugflag is often helpful for debugging HTTP client requests and responses.make lint). Note: This requires Docker to run inside a local job.Note
Expands supported pipeline variables used during local config validation.
pipeline.trigger.received_at,pipeline.trigger_source,pipeline.schedule.name,pipeline.schedule.id,pipeline.trigger_parameters.circleci.trigger_type,pipeline.trigger_parameters.circleci.event_type, andpipeline.event.context.github.pr_urltoLocalPipelineValuespipeline.trigger_parameters.circleci.event_timein favor ofpipeline.trigger.received_atWritten by Cursor Bugbot for commit 6324cd7. This will update automatically on new commits. Configure here.