-
Notifications
You must be signed in to change notification settings - Fork 244
Bring -e|--env args in line with docker
#487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bring -e|--env args in line with docker
#487
Conversation
able to share in /root/.circleci because Docker for Mac. Just use Vagrant.
Error: failed to start event processor: failed to compute task config: failed to read config file: read /tmp/local_build_config.yml: is a directory
Codecov Report
@@ Coverage Diff @@
## master #487 +/- ##
==========================================
- Coverage 26.84% 26.82% -0.02%
==========================================
Files 35 35
Lines 4739 4764 +25
==========================================
+ Hits 1272 1278 +6
- Misses 3341 3356 +15
- Partials 126 130 +4
Continue to review full report at Codecov.
|
|
Let me know whether there's interest in merging this and I'll try to fix up the code coverage. |
|
Ping. :) |
|
Ping on this. :) |
Closes #473
This closes the gap between how
docker run -e|--envandcircleci local execute -e|--envbehaves. Now, as indocker run, bare-e|--env VARarguments are resolved from the local environment and passed on topicardproperly. Arguments that are fully specified are never resolved from the environment and arguments are still required to be passed in order to forward them on topicard(i.e. there isn't any automatic inclusion of the environment in thepicardarguments).I'm happy to spin out the Vagrantfile if that's not welcome just yet but rather than figuring out to get Docker for Mac and golang set up on my MacBook I figured I'd just make an environment that anyone can benefit from.
Obviously I'd like to clean up the commits prior to merge but I wanted to get the discussion going.