fix: correct a bad pattern in schema #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirosen
changed the title
loderunner
approved these changes
Jul 8, 2025
pete-woods
force-pushed
the
fix-bad-schema-pattern
branch
from
876c68b to
1f8ecbe
Compare
pete-woods
approved these changes
Sep 30, 2025
pete-woods
force-pushed
the
fix-bad-schema-pattern
branch
from
1f8ecbe to
af25973
Compare
pete-woods
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #341
Implementation details
I've only fixed one issue with this pattern, which is the placement of the hyphen such that regex engines may interpret it as part of a character range.
There is at least one other suspicious irregularity, which is the
\/character sequence.Perhaps
\\/was meant. Or perhaps\\\\/. But the string does not appear to have been formulated with an eye to the layer of JSON escaping which is at play here.Absent any clarity on what the intention of this regex is, I've limited this fix to the hyphen issue only.
How to validate
Parse the expression using a variety of target regex engines -- JS is the presumptive target for this repo (?) -- and make sure it matches strings correctly.