Update Tauri release workflow for additional branch and paths#716
Merged
Update Tauri release workflow for additional branch and paths#716
Conversation
✅ Deploy Preview for circuitverse ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughMinor formatting change in the workflow matrix include. The frontend build step was changed to run Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
Fix all issues with AI Agents 🤖
In @.github/workflows/tauri-release.yml:
- Line 5: The workflow currently lists branches: [ "main", "tauri-test-2" ]
which will trigger draft release creation on every push to tauri-test-2; either
remove "tauri-test-2" from the branches array in
.github/workflows/tauri-release.yml or move the test branch into a separate
workflow file (e.g., tauri-release-test.yml) or add a paths or if condition to
the existing workflow to only run on specific files or tags so test pushes don’t
create draft releases.
- Around line 56-60: The workflow step uses "npx cross-env DESKTOP_MODE=true npm
run build" but cross-env is not declared in package.json; either add cross-env
to package.json devDependencies (install with npm/yarn as a dev dependency so CI
doesn't fetch it on every run) or explicitly document in repository/README that
the workflow relies on npx downloading cross-env at runtime and requires
internet access; update the workflow or documentation accordingly and ensure the
symbol "npx cross-env DESKTOP_MODE=true npm run build" and "package.json
devDependencies" are addressed.
- Around line 80-85: The workflow currently lists Windows-only artifact globs
"src-tauri/target/**/release/bundle/msi/*.msi" and
"src-tauri/target/**/release/bundle/nsis/*.exe" but the job matrix has no
Windows runner; either remove those two Windows-specific patterns from the
artifacts list or add a Windows runner to the matrix (e.g., include
"windows-latest" under the matrix key used by the release job or add a new
matrix entry) so the artifacts can be produced and uploaded.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/tauri-release.yml
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: senutpal
Repo: CircuitVerse/cv-frontend-vue PR: 706
File: .github/workflows/tauri-release.yml:51-51
Timestamp: 2025-12-30T10:11:52.399Z
Learning: In cv-frontend-vue repository, the tauri-action's `projectPath` should be set to `.` (root) because the `beforeBuildCommand` needs to run from the root directory where `package.json` and `dist/` are located. The Tauri CLI automatically locates `src-tauri/tauri.conf.json` from the project root.
📚 Learning: 2025-12-30T10:11:52.399Z
Learnt from: senutpal
Repo: CircuitVerse/cv-frontend-vue PR: 706
File: .github/workflows/tauri-release.yml:51-51
Timestamp: 2025-12-30T10:11:52.399Z
Learning: In cv-frontend-vue repository, the tauri-action's `projectPath` should be set to `.` (root) because the `beforeBuildCommand` needs to run from the root directory where `package.json` and `dist/` are located. The Tauri CLI automatically locates `src-tauri/tauri.conf.json` from the project root.
Applied to files:
.github/workflows/tauri-release.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build-tauri (ubuntu-22.04)
Comment on lines
+56
to
60
| # Using npx ensures these tools work on Windows, Mac, and Linux | ||
| run: | | ||
| npm run build | ||
| npx cross-env DESKTOP_MODE=true npm run build | ||
| node -e "const fs = require('fs'); const src='./dist/index-cv.html'; const dest='./dist/index.html'; if (fs.existsSync(src)) { fs.copyFileSync(src, dest); console.log('Synced index files'); } else { console.log('index-cv.html not found, skipping sync'); }" | ||
| working-directory: ./src |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check if cross-env is in ./src/package.json devDependencies
if [ -f "src/package.json" ]; then
echo "=== Content of src/package.json (devDependencies only) ==="
cat src/package.json | jq '.devDependencies | to_entries[] | select(.key | contains("cross-env")) | "\(.key): \(.value)"'
echo ""
echo "=== All devDependencies ==="
cat src/package.json | jq '.devDependencies | keys' 2>/dev/null || echo "No devDependencies found"
else
echo "src/package.json not found"
echo "Checking for package.json in root directory:"
cat package.json | jq '.devDependencies | to_entries[] | select(.key | contains("cross-env")) | "\(.key): \(.value)"' 2>/dev/null || echo "No cross-env in root package.json"
fiRepository: CircuitVerse/cv-frontend-vue
Length of output: 143
🏁 Script executed:
#!/bin/bash
# Check repository structure and package.json
echo "=== Checking for package.json files ==="
find . -name "package.json" -type f 2>/dev/null
echo ""
echo "=== Root directory structure ==="
ls -la | head -20
echo ""
echo "=== Contents of root package.json ==="
cat package.json | jq '.' 2>/dev/null | head -50
echo ""
echo "=== Checking for src directory ==="
ls -la src/ 2>/dev/null || echo "src directory not found"Repository: CircuitVerse/cv-frontend-vue
Length of output: 3906
🏁 Script executed:
#!/bin/bash
# Get complete devDependencies list to check for cross-env
cat package.json | jq '.devDependencies | keys' | grep -i cross-env || echo "Checking all devDependencies..."
cat package.json | jq '.devDependencies' | head -100Repository: CircuitVerse/cv-frontend-vue
Length of output: 801
Add cross-env to devDependencies or document the dependency on npx.
The code uses npx cross-env to ensure cross-platform environment variable support, but cross-env is not currently listed in the project's devDependencies. This means the tool will be downloaded on-the-fly each time the workflow runs.
Recommend either:
- Add
cross-envtodevDependenciesinpackage.jsonfor explicit dependency management, or - Document that this workflow depends on internet access to download
cross-envvianpx
🤖 Prompt for AI Agents
In @.github/workflows/tauri-release.yml around lines 56-60, The workflow step
uses "npx cross-env DESKTOP_MODE=true npm run build" but cross-env is not
declared in package.json; either add cross-env to package.json devDependencies
(install with npm/yarn as a dev dependency so CI doesn't fetch it on every run)
or explicitly document in repository/README that the workflow relies on npx
downloading cross-env at runtime and requires internet access; update the
workflow or documentation accordingly and ensure the symbol "npx cross-env
DESKTOP_MODE=true npm run build" and "package.json devDependencies" are
addressed.
Added Windows platform support for Tauri release workflow.
Removed 'tauri-test-2' branch from push triggers.
This was referenced Jan 7, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Describe the changes you have made in this PR -
Screenshots of the changes (If any) -
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.