Skip to content

fix: remove duplicate --br-circuit theme key#804

Merged
tachyons merged 1 commit intoCircuitVerse:mainfrom
Teesta-Mukherjee:main
Jan 17, 2026
Merged

fix: remove duplicate --br-circuit theme key#804
tachyons merged 1 commit intoCircuitVerse:mainfrom
Teesta-Mukherjee:main

Conversation

@Teesta-Mukherjee
Copy link
Contributor

@Teesta-Mukherjee Teesta-Mukherjee commented Jan 15, 2026

Fixes #789

What changed

Removed duplicate --br-circuit key from theme definitions to avoid build warnings and silent overrides.

Files updated

  • src/simulator/src/themer/themes.ts
  • v1/src/simulator/src/themer/themes.ts

Why

Duplicate CSS variable keys cause noisy esbuild warnings and make theme values ambiguous.

Code Understanding and AI Usage

Did you use AI assistance (ChatGPT, Claude, Copilot, etc.) to write any part of this code?

  • No, I wrote all the code myself
  • [ x ] Yes, I used AI assistance (continue below)

If you used AI assistance:

  • [ x ] I have reviewed every single line of the AI-generated code
  • I can explain the purpose and logic of each function/component I added
  • I have tested edge cases and understand how the code handles them
  • [ x ] I have modified the AI output to follow this project's coding standards and conventions

Explain your implementation approach:


Checklist before requesting a review

  • [ x ] I have added proper PR title and linked to the issue
  • I have performed a self-review of my code
  • I can explain the purpose of every function, class, and logic block I added
  • I understand why my changes work and have tested them thoroughly
  • I have considered potential edge cases and how my code handles them
  • If it is a core feature, I have added thorough tests
  • My code follows the project's style guidelines and conventions

Note: Please check Allow edits from maintainers if you would like us to assist in the PR.

Summary by CodeRabbit

Release Notes

  • Refactor
    • Removed the --br-circuit CSS custom property from default and custom theme definitions.

✏️ Tip: You can customize this high-level summary in your review settings.

@netlify
Copy link

netlify bot commented Jan 15, 2026

Deploy Preview for circuitverse ready!

Name Link
🔨 Latest commit 1beb569
🔍 Latest deploy log https://app.netlify.com/projects/circuitverse/deploys/696969d3e634fc00082804c4
😎 Deploy Preview https://deploy-preview-804--circuitverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 43 (🔴 down 3 from production)
Accessibility: 73 (no change from production)
Best Practices: 92 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 15, 2026

Walkthrough

This pull request removes the CSS variable --br-circuit from the Default Theme and Custom Theme definitions in both src/simulator/src/themer/themes.ts and v1/src/simulator/src/themer/themes.ts files. The CSS variable was defined multiple times within these theme objects, causing duplicate key declarations that resulted in build warnings. The removal eliminates these duplicate definitions while leaving all other theme properties and the overall theming structure intact.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: remove duplicate --br-circuit theme key' clearly and specifically summarizes the main change: removing a duplicate CSS variable key from theme definitions.
Linked Issues check ✅ Passed The pull request successfully addresses all coding requirements from issue #789 by removing the duplicate --br-circuit CSS variable from both Default and Custom theme definitions.
Out of Scope Changes check ✅ Passed All changes in the pull request are directly related to removing the duplicate --br-circuit CSS variable from theme files as specified in the linked issue, with no out-of-scope modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0e58e46 and 1beb569.

📒 Files selected for processing (2)
  • src/simulator/src/themer/themes.ts
  • v1/src/simulator/src/themer/themes.ts
💤 Files with no reviewable changes (2)
  • v1/src/simulator/src/themer/themes.ts
  • src/simulator/src/themer/themes.ts

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Teesta-Mukherjee
Copy link
Contributor Author

hello @tachyons @ThatDeparted2061.This is ready to be reviewed please consider.

@tachyons tachyons merged commit b618543 into CircuitVerse:main Jan 17, 2026
14 checks passed
abhiraj75 pushed a commit to abhiraj75/cv-frontend-vue that referenced this pull request Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞 Bug: Duplicate CSS variable keys in theme definitions cause build warnings

2 participants