Skip to content

fix: panel buttons unresponsive after window resize #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nihal4777 merged 6 commits into from
Feb 8, 2026
Merged

fix: panel buttons unresponsive after window resize #882

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
65a2d8a
fix: panel buttons unresponsive after window resize
senutpal Jan 28, 2026
96a724d
fix: make setupPanelListeners idempotent with namespaced events
senutpal Feb 4, 2026
b5254a0
fix: implement review suggestions
senutpal Feb 8, 2026
5005790
Merge branch 'main' into fix/panel-buttons-unresponsive-after-resize-…
Nihal4777 Feb 8, 2026
0a8af94
fix: implement coderabbit suggestion
senutpal Feb 8, 2026
af56bdb
Merge branch 'fix/panel-buttons-unresponsive-after-resize-#874' of ht…
senutpal Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/Panels/ElementsPanel/ElementsPanel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ onBeforeMount(() => {

onMounted(() => {
layoutStore.elementsPanelRef = elementsPanelRef.value
window.setupPanelListeners?.('.elementPanel')
})

var elementInput = ref('')
Expand Down
1 change: 1 addition & 0 deletions src/components/Panels/PropertiesPanel/PropertiesPanel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,6 @@ const propertiesPanelStore = usePropertiesPanelStore();
onMounted(() => {
// checks for which type of properties panel to show
setInterval(showPropertiesPanel, 100)
window.setupPanelListeners?.('#moduleProperty')
})
</script>
2 changes: 2 additions & 0 deletions src/components/Panels/TestBenchPanel/TestBenchPanel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,8 @@ const testbenchPanelRef = ref<HTMLElement | null>(null);

onMounted(() => {
layoutStore.testbenchPanelRef = testbenchPanelRef.value
window.setupPanelListeners?.('.testbench-manual-panel')
window.minimizePanel?.('.testbench-manual-panel')
})

const testData = computed(() => testBenchStore.testbenchData?.testData);
Expand Down
2 changes: 2 additions & 0 deletions src/components/Panels/TimingDiagramPanel/TimingDiagramPanel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ const timingDiagramPanelStore = useTimingDiagramPanelStore();

onMounted(() => {
layoutStore.timingDiagramPanelRef = timingDiagramPanelStore.timingDiagramPanelRef
window.setupPanelListeners?.('.timing-diagram-panel')
window.minimizePanel?.('.timing-diagram-panel')
})
</script>

Expand Down
45 changes: 28 additions & 17 deletions src/simulator/src/ux.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,11 @@ $('#octalInput').on('keyup', () => {
setBaseValues(x)
})

window.setupPanelListeners = setupPanelListeners

window.minimizePanel = (panelSelector) => {
$(panelSelector + ' .minimize').trigger('click')
}
export function setupPanels() {
dragging('#dragQPanel', '.quick-btn')

Expand Down Expand Up @@ -381,25 +386,31 @@ function setupPanelListeners(panelSelector) {
dragging(headerSelector, panelSelector)
// Current Panel on Top
var minimized = false
$(headerSelector).on('dblclick', () =>
minimized
? $(maximizeSelector).trigger('click')
: $(minimizeSelector).trigger('click')
)
$(headerSelector)
.off('dblclick.panelListeners')
.on('dblclick.panelListeners', () =>
minimized
? $(maximizeSelector).trigger('click')
: $(minimizeSelector).trigger('click')
)
// Minimize
$(minimizeSelector).on('click', () => {
$(bodySelector).hide()
$(minimizeSelector).hide()
$(maximizeSelector).show()
minimized = true
})
$(minimizeSelector)
.off('click.panelListeners')
.on('click.panelListeners', () => {
$(bodySelector).hide()
$(minimizeSelector).hide()
$(maximizeSelector).show()
minimized = true
})
// Maximize
$(maximizeSelector).on('click', () => {
$(bodySelector).show()
$(minimizeSelector).show()
$(maximizeSelector).hide()
minimized = false
})
$(maximizeSelector)
.off('click.panelListeners')
.on('click.panelListeners', () => {
$(bodySelector).show()
$(minimizeSelector).show()
$(maximizeSelector).hide()
minimized = false
})
}

export function exitFullView() {
Expand Down
1 change: 1 addition & 0 deletions v1/src/components/Panels/ElementsPanel/ElementsPanel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ onBeforeMount(() => {

onMounted(() => {
layoutStore.elementsPanelRef = elementsPanelRef.value
window.setupPanelListeners?.('.elementPanel')
})

var elementInput = ref('')
Expand Down
1 change: 1 addition & 0 deletions v1/src/components/Panels/PropertiesPanel/PropertiesPanel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,6 @@ const propertiesPanelStore = usePropertiesPanelStore();
onMounted(() => {
// checks for which type of properties panel to show
setInterval(showPropertiesPanel, 100)
window.setupPanelListeners?.('#moduleProperty')
})
</script>
2 changes: 2 additions & 0 deletions v1/src/components/Panels/TestBenchPanel/TestBenchPanel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,8 @@ const testbenchPanelRef = ref<HTMLElement | null>(null);

onMounted(() => {
layoutStore.testbenchPanelRef = testbenchPanelRef.value
window.setupPanelListeners?.('.testbench-manual-panel')
window.minimizePanel?.('.testbench-manual-panel')
})

const testData = computed(() => testBenchStore.testbenchData?.testData);
Expand Down
2 changes: 2 additions & 0 deletions v1/src/components/Panels/TimingDiagramPanel/TimingDiagramPanel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ const timingDiagramPanelStore = useTimingDiagramPanelStore();

onMounted(() => {
layoutStore.timingDiagramPanelRef = timingDiagramPanelStore.timingDiagramPanelRef
window.setupPanelListeners?.('.timing-diagram-panel')
window.minimizePanel?.('.timing-diagram-panel')
})
</script>

Expand Down
46 changes: 29 additions & 17 deletions v1/src/simulator/src/ux.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,12 @@ $('#octalInput').on('keyup', () => {
setBaseValues(x)
})

window.setupPanelListeners = setupPanelListeners

window.minimizePanel = (panelSelector) => {
$(panelSelector + ' .minimize').trigger('click')
}

export function setupPanels() {
dragging('#dragQPanel', '.quick-btn')

Expand Down Expand Up @@ -381,25 +387,31 @@ function setupPanelListeners(panelSelector) {
dragging(headerSelector, panelSelector)
// Current Panel on Top
var minimized = false
$(headerSelector).on('dblclick', () =>
minimized
? $(maximizeSelector).trigger('click')
: $(minimizeSelector).trigger('click')
)
$(headerSelector)
.off('dblclick.panelListeners')
.on('dblclick.panelListeners', () =>
minimized
? $(maximizeSelector).trigger('click')
: $(minimizeSelector).trigger('click')
)
// Minimize
$(minimizeSelector).on('click', () => {
$(bodySelector).hide()
$(minimizeSelector).hide()
$(maximizeSelector).show()
minimized = true
})
$(minimizeSelector)
.off('click.panelListeners')
.on('click.panelListeners', () => {
$(bodySelector).hide()
$(minimizeSelector).hide()
$(maximizeSelector).show()
minimized = true
})
// Maximize
$(maximizeSelector).on('click', () => {
$(bodySelector).show()
$(minimizeSelector).show()
$(maximizeSelector).hide()
minimized = false
})
$(maximizeSelector)
.off('click.panelListeners')
.on('click.panelListeners', () => {
$(bodySelector).show()
$(minimizeSelector).show()
$(maximizeSelector).hide()
minimized = false
})
}

export function exitFullView() {
Expand Down
Loading