Skip to content

fix: right-click delete in lower part of board (#829) #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nakshatra480 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: right-click delete in lower part of board (#829) #893

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c4f4ff
fix: right-click delete in lower part of board (#829)
Jan 29, 2026
7601e4d
fix: restore mouseDown state after context menu sync
Jan 29, 2026
657a078
fix: right click delete in lower part of board (#829)
Jan 31, 2026
c8a4765
fix: complete right-click delete in lower canvas (DPR + z-index + eve…
Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion src/simulator/src/ux.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ import { layoutModeGet } from './layoutMode'
import {
scheduleUpdate,
wireToBeCheckedSet,
updateCanvasSet
updateCanvasSet,
update
} from './engine'
import { simulationArea } from './simulationArea'
import logixFunction from './data'
Expand Down Expand Up @@ -53,12 +54,38 @@ function hideContextMenu() {
ctxPos.visible = false
}, 200) // Hide after 2 sec
}

var UNIT = 10

function syncSelectionToContextMenuPosition() {
var canvas = simulationArea.canvas
if (!canvas || typeof globalScope === 'undefined') return
var rect = canvas.getBoundingClientRect()
var rawX = (ctxPos.x - rect.left) * DPR
var rawY = (ctxPos.y - rect.top) * DPR
simulationArea.mouseDownRawX = rawX
simulationArea.mouseDownRawY = rawY
simulationArea.mouseDownX = Math.round(((rawX - globalScope.ox) / globalScope.scale) / UNIT) * UNIT
simulationArea.mouseDownY = Math.round(((rawY - globalScope.oy) / globalScope.scale) / UNIT) * UNIT
simulationArea.mouseRawX = rawX
simulationArea.mouseRawY = rawY
simulationArea.mouseXf = (rawX - globalScope.ox) / globalScope.scale
simulationArea.mouseYf = (rawY - globalScope.oy) / globalScope.scale
simulationArea.mouseX = simulationArea.mouseDownX
simulationArea.mouseY = simulationArea.mouseDownY
var wasMouseDown = simulationArea.mouseDown
simulationArea.mouseDown = true
update(globalScope, true)
simulationArea.mouseDown = wasMouseDown
}

/**
* Function displays context menu
* @category ux
*/
function showContextMenu() {
if (layoutModeGet()) return false // Hide context menu when it is in Layout Mode
syncSelectionToContextMenuPosition()
$('#contextMenu').css({
visibility: 'visible',
opacity: 1,
Expand Down
29 changes: 28 additions & 1 deletion v1/src/simulator/src/ux.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ import { layoutModeGet } from './layoutMode'
import {
scheduleUpdate,
wireToBeCheckedSet,
updateCanvasSet
updateCanvasSet,
update
} from './engine'
import { simulationArea } from './simulationArea'
import logixFunction from './data'
Expand Down Expand Up @@ -53,12 +54,38 @@ function hideContextMenu() {
ctxPos.visible = false
}, 200) // Hide after 2 sec
}

var UNIT = 10

function syncSelectionToContextMenuPosition() {
var canvas = simulationArea.canvas
if (!canvas || typeof globalScope === 'undefined') return
var rect = canvas.getBoundingClientRect()
var rawX = (ctxPos.x - rect.left) * DPR
var rawY = (ctxPos.y - rect.top) * DPR
simulationArea.mouseDownRawX = rawX
simulationArea.mouseDownRawY = rawY
simulationArea.mouseDownX = Math.round(((rawX - globalScope.ox) / globalScope.scale) / UNIT) * UNIT
simulationArea.mouseDownY = Math.round(((rawY - globalScope.oy) / globalScope.scale) / UNIT) * UNIT
simulationArea.mouseRawX = rawX
simulationArea.mouseRawY = rawY
simulationArea.mouseXf = (rawX - globalScope.ox) / globalScope.scale
simulationArea.mouseYf = (rawY - globalScope.oy) / globalScope.scale
simulationArea.mouseX = simulationArea.mouseDownX
simulationArea.mouseY = simulationArea.mouseDownY
var wasMouseDown = simulationArea.mouseDown
simulationArea.mouseDown = true
update(globalScope, true)
simulationArea.mouseDown = wasMouseDown
}

/**
* Function displays context menu
* @category ux
*/
function showContextMenu() {
if (layoutModeGet()) return false // Hide context menu when it is in Layout Mode
syncSelectionToContextMenuPosition()
$('#contextMenu').css({
visibility: 'visible',
opacity: 1,
Expand Down