-
Notifications
You must be signed in to change notification settings - Fork 230
Fix: Remove unused props variable in BooleanTable.vue #900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for circuitverse ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThis PR makes localized, non-behavioral changes across several Vue components: BooleanTable.vue replaces a direct Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
92e1880 to
91f8a57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/components/DialogBox/BooleanTable.vue`:
- Around line 19-22: Destructuring props directly from defineProps makes
tableHeader and tableBody non-reactive; update the props handling in the
component so the values remain reactive by using toRefs on the object returned
from defineProps (keep the defineProps call but wrap its result with toRefs and
use the toRef-ed symbols tableHeader and tableBody in the template and v-for
loops); ensure any existing references to tableHeader/tableBody in methods or
computed properties use the reactive refs instead of plain values.
🧹 Nitpick comments (1)
src/components/Extra.vue (1)
39-40: Prefer guaranteed-unique keys if messages can repeat.Using the message text as
:keycan collide when duplicates exist. Consider adding an index or stable id to keep keys unique.🧩 Example tweak for uniqueness
-<div v-for="mes in useState().successMessages" :key="mes" class='alert alert-success' role='alert'> {{ mes }}</div> -<div v-for="error in useState().errorMessages" :key="error" class='alert alert-danger' role='alert'> {{ error }}</div> +<div v-for="(mes, idx) in useState().successMessages" :key="`success-${idx}-${mes}`" class='alert alert-success' role='alert'> {{ mes }}</div> +<div v-for="(error, idx) in useState().errorMessages" :key="`error-${idx}-${error}`" class='alert alert-danger' role='alert'> {{ error }}</div>
314d245 to
77e9fe9
Compare
This debug console.log was accidentally left in the code and could potentially log sensitive user data. Removing it to keep things secure.
Destructured the props in the setup script to avoid the ESLint unused variable warning. Improved type safety by defining props with strict TypeScript types (string[] for tableHeader, string[][] for tableBody) instead of loose Array types. Added JSDoc comments for better documentation. The props are used directly in the template for displaying table data.
77e9fe9 to
ff10207
Compare
|
@Nihal4777 please review the PR and merge it if possible |
|
Hi @s1dhu98, thanks for taking the time to create this PR. |

Destructured the props in the setup script to avoid the ESLint unused variable warning. The props are used directly in the template.
Summary by CodeRabbit
Bug Fixes
Style
Chores
✏️ Tip: You can customize this high-level summary in your review settings.