-
Notifications
You must be signed in to change notification settings - Fork 230
Fix vue v for keys #902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix vue v for keys #902
Conversation
WalkthroughThis pull request updates multiple UI components and simulator UX code: Extra.vue adds explicit keys for v-for message lists and adjusts mobile button conditional rendering and template formatting; UserMenu.vue removes debug console logs from the authentication flow; NavbarLink2.vue removes the lifecycle-driven ui:close-menus handler and its listeners; simulator/src/ux.js simplifies fullView/exitFullView by removing prior saved mobile state and related guards and directly toggling simulatorMobileStore flags. Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for circuitverse ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/components/Extra.vue`:
- Around line 39-40: The current v-for uses the message string as the key
(useState().successMessages and useState().errorMessages), which can produce
duplicate keys for repeated messages; update both loops to include the index
(e.g., iterate as (mes, idx) and (error, idx)) and use an index-based key
(preferably prefixed like "success-<idx>" and "error-<idx>") so each rendered
item has a unique key and avoids Vue duplicate-key warnings.
🧹 Nitpick comments (2)
src/components/Extra.vue (2)
88-89: Inconsistent attribute indentation.The
idattribute appears unindented on line 89 after the line break, which is inconsistent with similar elements in the file (e.g.,simulationAreacanvas at lines 97-98 has proper indentation).Suggested formatting fix
<canvas -id="backgroundArea" style=" + id="backgroundArea" + style=" position: absolute;
137-138: Same indentation inconsistency as above.The
classattribute lacks proper indentation after the line break.Suggested formatting fix
<div -class="sk-folding-cube loadingIcon" style=" + class="sk-folding-cube loadingIcon" + style=" display: none;
This debug console.log was accidentally left in the code and could potentially log sensitive user data. Removing it to keep things secure.
7558d35 to
9a22b16
Compare
9a22b16 to
15026c4
Compare
|
@Nihal4777 kindly review the PR and merge if possible |
|
@s1dhu98 Kindly refer contribution guidelines and follow proper PR template. |
|
@Nihal4777 pull request template has been update kindly review it |
|
Hey @s1dhu98 please fill in the PR description as per the template. Thanks! |

Fixed missing :key attributes on v-for loops in Extra.vue. Vue needs unique keys to properly track list items, otherwise it causes rendering issues with dynamic message lists.
Also cleaned up the codebase:
All changes applied to both v0 and v1 versions consistently