Skip to content

Conversation

@Git-HimanshuRathi
Copy link
Contributor

@Git-HimanshuRathi Git-HimanshuRathi commented Feb 2, 2026

Fixes #895

Summary

Tests pass locally with npm ci and npm test.

Code Understanding and AI Usage

Did you use AI assistance (ChatGPT, Claude, Copilot, etc.) to write any part of this code?

  • No, I wrote all the code myself
  • Yes, I used AI assistance (continue below)

If you used AI assistance:

  • I have reviewed every single line of the AI-generated code
  • I can explain the purpose and logic of each function/component I added
  • I have tested edge cases and understand how the code handles them
  • I have modified the AI output to follow this project's coding standards and conventions

Explain your implementation approach:


Checklist before requesting a review

  • I have added proper PR title and linked to the issue
  • I have performed a self-review of my code
  • I can explain the purpose of every function, class, and logic block I added
  • I understand why my changes work and have tested them thoroughly
  • I have considered potential edge cases and how my code handles them
  • If it is a core feature, I have added thorough tests
  • My code follows the project's style guidelines and conventions

Note: Please check Allow edits from maintainers if you would like us to assist in the PR.

Summary by CodeRabbit

  • Chores
    • Updated CI workflow to run matrix tests across versions and OSes, increased timeout to 15 minutes, and added project-specific test parameters.
    • Added Rust toolchain and platform build dependencies for cross-platform testing.
    • Bumped application and packaging versions to 0.0.5.

Add GitHub Actions workflow to run tests for the Tauri desktop app
across Ubuntu, Windows, and macOS platforms.

- Uses Node 20 LTS for stability
- Runs vitest with existing Tauri API mocks
- Job matrix for cross-platform testing

Closes CircuitVerse#895
@netlify
Copy link

netlify bot commented Feb 2, 2026

Deploy Preview for circuitverse ready!

Name Link
🔨 Latest commit 5f1463d
🔍 Latest deploy log https://app.netlify.com/projects/circuitverse/deploys/69885431ad484c000845f0e5
😎 Deploy Preview https://deploy-preview-914--circuitverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 46 (🔴 down 3 from production)
Accessibility: 73 (no change from production)
Best Practices: 92 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 2, 2026

Walkthrough

The pull request updates CI and package metadata: it replaces the vitest GitHub Actions workflow with a matrix-based job testing two project versions (src, v1) across three OSes (ubuntu-latest, windows-latest, macos-latest), sets runs-on to the matrix OS, disables fail-fast, increases job timeout to 15 minutes, changes Node.js version to 20, installs the Rust stable toolchain and Linux-specific native deps on Ubuntu, reuses npm ci, and passes --project=${{ matrix.version }} to the test command. It also bumps versions in package.json, src-tauri/Cargo.toml, and src-tauri/tauri.conf.json from 0.0.0 to 0.0.5.

Possibly related PRs

  • cv-frontend-vue PR 636: Modifies the same project version files (package.json, src-tauri/Cargo.toml, src-tauri/tauri.conf.json) and adjusts GitHub Actions workflows for desktop CI/release.
  • cv-frontend-vue PR 871: Extends and parameterizes the .github/workflows/vitest.yml workflow, adding a matrix, OS-specific setup, and project-aware test invocation.
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The PR includes version bumps (0.0.0 to 0.0.5) in package.json, Cargo.toml, and tauri.conf.json that are not directly related to adding the testing workflow, though they appear to be routine maintenance. Clarify whether version bumps are intentional and required for this workflow addition, or move them to a separate maintenance PR to keep the scope focused on the testing workflow.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'ci: add Tauri desktop testing workflow' accurately describes the main change, which introduces a GitHub Actions workflow for testing the Tauri desktop application.
Linked Issues check ✅ Passed The PR fulfills all coding requirements from issue #895: it adds a GitHub Actions workflow (vitest.yml matrix), maintains compatibility with the existing setup, includes OS-specific dependency installation (Rust, Linux deps), and does not change application logic.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Git-HimanshuRathi
Copy link
Contributor Author

ready for review @tachyons @ThatDeparted2061 .

@tachyons
Copy link
Member

tachyons commented Feb 2, 2026

What exactly is being tested here, unit tests are being run another workflow and tauri build is being tested on another workflow. What is being tested here ?

@Git-HimanshuRathi
Copy link
Contributor Author

This workflow doesn’t add any new tests or duplicate the Tauri build step.

What it changes is where the existing tests run:
• vitest.yml currently runs the test suite on Ubuntu only
• tauri-tests.yml runs the same Vitest tests on Ubuntu, Windows, and macOS using a job matrix

Why this is useful for Tauri:
• The current Vitest setup already mocks Tauri APIs (from #871)
• Some desktop-related issues (paths, OS specific behavior, native deps) can pass on Linux but fail on Windows or macOS
• Running the tests across all platforms helps catch those issues earlier, before the build step

If you’d prefer this to be added into the existing vitest.yml as a matrix instead of a separate workflow, I’m happy to change that.

@tachyons
Copy link
Member

tachyons commented Feb 2, 2026

Please merge with existing test suit, and make it matrix. Two layers of matrices, one for version and another for OS

- Add two-layer matrix: version (src, v1) x OS (ubuntu, windows, macos)
- Remove separate tauri-tests.yml per maintainer feedback
- Use Node 20 LTS for stability
- Add Rust toolchain and Linux dependencies for Tauri testing
- Use --project flag to run specific workspace version

This creates 6 job combinations to ensure cross-platform testing.

Closes CircuitVerse#895
@Git-HimanshuRathi
Copy link
Contributor Author

@tachyons it's done .

@ThatDeparted2061
Copy link
Member

ThatDeparted2061 commented Feb 3, 2026

can you add a screen shot for the tests, coz the mocking of api shudnt be working for Tauri testing.
https://v2.tauri.app/develop/tests/mocking/

@Git-HimanshuRathi
Copy link
Contributor Author

Git-HimanshuRathi commented Feb 3, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CI workflow for testing Tauri desktop application

3 participants