Skip to content

CI-739 - Use Full Object checksum when uploading via S3 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 11, 2025
Merged

CI-739 - Use Full Object checksum when uploading via S3 #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ad916c
specify full object checksum when uploading
nathanthorpe Sep 11, 2025
41a5c4a
bump version
nathanthorpe Sep 11, 2025
984310c
update versions
nathanthorpe Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/api-client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@cirrobio/api-client",
"version": "0.10.5",
"version": "0.10.6",
"description": "API client for Cirro",
"author": "CirroBio",
"repository": {
Expand Down
4 changes: 2 additions & 2 deletions packages/react-auth/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@
"test": "jest --coverage --silent --passWithNoTests"
},
"dependencies": {
"@cirrobio/api-client": "^0.9.0",
"@cirrobio/api-client": "^0.10.0",
"@cirrobio/react-core": "^0.0.1",
"@cirrobio/sdk": "^0.9.0",
"@cirrobio/sdk": "^0.10.0",
"@mui/icons-material": "^5.17.1",
"@mui/lab": "^5.0.0-alpha.176",
"@mui/material": "^5.15.10",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"test": "jest --coverage --silent --passWithNoTests"
},
"dependencies": {
"@cirrobio/sdk": "^0.9.0"
"@cirrobio/sdk": "^0.10.0"
},
"peerDependencies": {
"react": "^16.14 || ^17 || ^18 || ^19"
Expand Down
4 changes: 2 additions & 2 deletions packages/react-tool/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@
"test": "jest --coverage --silent --passWithNoTests"
},
"dependencies": {
"@cirrobio/api-client": "^0.9.0",
"@cirrobio/api-client": "^0.10.0",
"@cirrobio/react-auth": "^0.0.1",
"@cirrobio/react-core": "^0.0.1",
"@cirrobio/sdk": "^0.9.0"
"@cirrobio/sdk": "^0.10.0"
},
"peerDependencies": {
"@emotion/react": "^11.11.3",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-ui-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"test": "jest --coverage --silent --passWithNoTests"
},
"dependencies": {
"@cirrobio/sdk": "^0.9.0"
"@cirrobio/sdk": "^0.10.0"
},
"peerDependencies": {
"@emotion/react": "^11.11.3",
Expand Down
10 changes: 5 additions & 5 deletions packages/sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@cirrobio/sdk",
"version": "0.10.5",
"version": "0.10.6",
"description": "SDK for Cirro",
"author": "CirroBio",
"repository": {
Expand Down Expand Up @@ -30,10 +30,10 @@
"preset": "ts-jest"
},
"dependencies": {
"@aws-sdk/client-s3": "^3.34.0",
"@aws-sdk/lib-storage": "^3.34.0",
"@aws-sdk/s3-request-presigner": "^3.34.0",
"@cirrobio/api-client": "^0.10.1",
"@aws-sdk/client-s3": "^3.886.0",
"@aws-sdk/lib-storage": "^3.886.0",
"@aws-sdk/s3-request-presigner": "^3.886.0",
"@cirrobio/api-client": "^0.10.2",
"uuid": "^11.1.0"
},
"devDependencies": {
Expand Down
6 changes: 4 additions & 2 deletions packages/sdk/src/file/actions/upload.fn.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { Upload } from "@aws-sdk/lib-storage";
import { AWSCredentials } from '@cirrobio/api-client';
import { createS3Client } from "../util/s3-client";
import { PutObjectCommandInput } from "@aws-sdk/client-s3";
import { CreateMultipartUploadRequest } from "@aws-sdk/client-s3/dist-types/models/models_0";

export interface UploadFileParams {
bucket: string;
Expand All @@ -15,12 +16,13 @@ export interface UploadFileParams {
* Upload a file to S3
*/
export function uploadFile({ bucket, path, file, credentials, metadata }: UploadFileParams): Upload {
const params: PutObjectCommandInput = {
const params: PutObjectCommandInput & CreateMultipartUploadRequest = {
Bucket: bucket,
Key: path,
Body: file,
ContentType: file.type,
Metadata: metadata
Metadata: metadata,
ChecksumType: "FULL_OBJECT"
};
return new Upload({
client: createS3Client(credentials),
Expand Down
Loading