@@ -1162,9 +1162,9 @@ static int tacna_pin_probe(struct platform_device *pdev)
11621162
11631163 tacna_pin_desc .npins = priv -> chip -> n_pins ;
11641164
1165- priv -> pctl = pinctrl_register ( & tacna_pin_desc , & pdev -> dev , priv );
1166- if ( IS_ERR ( priv -> pctl )) {
1167- ret = PTR_ERR ( priv -> pctl );
1165+ ret = devm_pinctrl_register_and_init ( & pdev -> dev , & tacna_pin_desc , priv ,
1166+ & priv -> pctl );
1167+ if ( ret ) {
11681168 dev_err (priv -> dev , "Failed pinctrl register (%d)\n" , ret );
11691169 return ret ;
11701170 }
@@ -1177,23 +1177,19 @@ static int tacna_pin_probe(struct platform_device *pdev)
11771177 return ret ;
11781178 }
11791179
1180- dev_dbg (priv -> dev , "pinctrl registered\n" );
1181-
1182- return 0 ;
1183- }
1184-
1185- static int tacna_pin_remove (struct platform_device * pdev )
1186- {
1187- struct tacna_pin_private * priv = platform_get_drvdata (pdev );
1180+ ret = pinctrl_enable (priv -> pctl );
1181+ if (ret ) {
1182+ dev_err (priv -> dev , "Failed to enable pinctrl (%d)\n" , ret );
1183+ return ret ;
1184+ }
11881185
1189- pinctrl_unregister (priv -> pctl );
1186+ dev_dbg (priv -> dev , "pinctrl registered\n" );
11901187
11911188 return 0 ;
11921189}
11931190
11941191static struct platform_driver tacna_pin_driver = {
11951192 .probe = & tacna_pin_probe ,
1196- .remove = & tacna_pin_remove ,
11971193 .driver = {
11981194 .name = "tacna-pinctrl" ,
11991195 },
0 commit comments