Issues #251 and #264 in ansible solutions. #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IPv6 address inventory failure.
NDFC returns ipv6 address with unabbrevated form (e.g) 2001:0:0:12 instead of 2001::12 for below requests.
/appcenter/cisco/ndfc/api/v1/lan-fabric/rest/lanConfig/getLanSwitchCredentials
"ipAddress": "2001:420:448b:8006:fab2:0:0:13",
/appcenter/cisco/ndfc/api/v1/lan-fabric/rest/control/fabrics/hello/inventory/test-reachability
in netascode/ansible-dc-vxlan#251
mikewiebe
reviewed
Jan 17, 2025
| tags: sanity | ||
|
|
||
| - { include: dcnm.yaml, tags: ['dcnm'] } | ||
| - { include_tasks: dcnm.yaml, tags: ['dcnm'] } |
Collaborator
There was a problem hiding this comment.
I merged #354 which introduced a merge conflict for this file.
Collaborator
Author
There was a problem hiding this comment.
Resolved the merge conflict
| or isinstance(ipaddress.ip_address(ip_addr), ipaddress.IPv4Address)): | ||
| sw_ip = str(ipaddress.ip_address(ip_addr)) | ||
| except ValueError: | ||
| sw_ip = ip_addr |
Collaborator
There was a problem hiding this comment.
Help me understand the intent here. Why are we just setting sw_ip to the value that was passed in if we encounter an error?
Collaborator
Author
There was a problem hiding this comment.
During my UT, Observed couple of cases where have_c["switches"][0]["ipaddr"] was empty. Continuing the existing code flow if it is not of instance type "ipaddress"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPv6 address inventory failure.
NDFC returns ipv6 address in unabbrevated form (e.g) 2001:0:0:12 instead of 2001::12 for below requests. It mismatches value in inventory and NDFC response.
/appcenter/cisco/ndfc/api/v1/lan-fabric/rest/lanConfig/getLanSwitchCredentials
"ipAddress": "2001:420:448b:8006:fab2:0:0:13",
/appcenter/cisco/ndfc/api/v1/lan-fabric/rest/control/fabrics/hello/inventory/test-reachability
in netascode/ansible-dc-vxlan#251