-
Notifications
You must be signed in to change notification settings - Fork 49
OneManage: endpoints #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
OneManage: endpoints #521
Changes from 29 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
a713823
OneManage endpoints: initial commit
allenrobel d64bff5
Merge branch 'develop' into mcfg-endpoints
allenrobel fcd8209
OneManage: comment out unused imports for now
allenrobel f128d29
EpOneManageFabricDetails: fix docstring
allenrobel 887f5f0
EpOneManageFabricCreate: new endpoint class
allenrobel 5ca9361
Complete the remaining OneManage endpoint classes
allenrobel eae7e12
Python 3.111 backward compatibility changes
allenrobel fa65b70
Minor docstring update for query param classes
allenrobel 0a3f2d7
Update Python dependencies in workflow
allenrobel 3263e9e
Update Pydantic version to 2.11.10
allenrobel 701a89b
Add Requests installation step to workflow
allenrobel 8bd17d3
Remove Pydantic and Requests installation steps
allenrobel 562eba1
Add tests/requirements.txt
allenrobel 49bd6eb
Add tests/sanity/requirements.txt
allenrobel bc1bda9
Add pydantic to requirements.txt
allenrobel 608141c
onemanage/endpoints.py: Add import guard
allenrobel 3245f36
Update tests/sanity/ignore*.txt
allenrobel c55dba9
common/api/query_params.py: Add import guard
allenrobel a7cbb83
common/api/base_paths.py: Unit tests
allenrobel 3a08709
common/api/query_params.py: Unit tests
allenrobel 52c88d6
# Summary
allenrobel cfb4e15
Appease pylint
allenrobel 649bcbf
Add remaining OneManage endpoints and unit tests
allenrobel 10a7ea6
Sort query parameter and endpoint classes by name
allenrobel 51f80fc
Appease pylint
allenrobel 8ee9d8c
EpOneManageFabricMembersGet: Rename
allenrobel a751c06
Update unit tests for EpOneManageFabricGroupMembersGet
allenrobel 4f82eaf
endpoints.py: make class_name optional with default
allenrobel c2457f2
endpoints.py: class_name should be Optional[str]
allenrobel 65d9978
Use ND rather than DCNM/NDFC in comments/docs
allenrobel 3db46f7
Sanity: Remove import-3.x!skip for endpoints.py
allenrobel ebb500b
Try workaround for Sanity test failures
allenrobel cb4998d
Fix import guards
allenrobel b12250d
Fallbacks for BaseModel,Field,field_validator
allenrobel a3fc412
Fix Field() positional argument error
allenrobel 55e1586
Same fix as last commit, but different location
allenrobel 8e2e7c3
Fix Field() positional argument error
allenrobel 40f420f
Fix Field(default_factory) assignments
allenrobel 2fa308e
1. Remove custom __init__() method from endpoint classes that initial…
allenrobel 1744d36
LuceneQueryParams: add Field(default=None)
allenrobel 8ad7a42
Merge branch 'develop' into onemanage-endpoints
allenrobel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -102,16 +102,22 @@ jobs: | |
|
|
||
| - name: Install ansible-base (v${{ matrix.ansible }}) | ||
| run: pip install https://github.com/ansible/ansible/archive/v${{ matrix.ansible }}.tar.gz --disable-pip-version-check | ||
|
|
||
| - name: Install Pydantic (v2) | ||
| run: pip install pydantic==2.11.10 | ||
|
|
||
| - name: Install Requests | ||
| run: pip install requests==2.32.5 | ||
|
|
||
| - name: Install DeepDiff (v8.5.0) | ||
| run: pip install deepdiff==8.5.0 | ||
|
|
||
| - name: Install coverage (v7.3.4) | ||
| run: pip install coverage==7.3.4 | ||
|
|
||
| - name: Install pytest (v7.4.4) | ||
| run: pip install pytest==7.4.4 | ||
|
|
||
| - name: Install requests | ||
| run: pip install requests | ||
|
|
||
| - name: Download migrated collection artifacts | ||
| uses: actions/[email protected] | ||
| with: | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the determining factor in choosing these specific versions of (Pydantic, Requests, DeepDiff)?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No determining factors really. These were just the versions I had installed locally. I've removed the version constraint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am actually not against pinning to a specific version and then only updating when we have tested. I was just curious if you ran into issues with other versions. I would prefer we pin and only move strategically after testing.