1385 access port block migration (DCNE-556) #1400
Open
+20,839
−3,666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor, fex_profile. leaf_interface_profile, spine_interface_profile and spine_access_port_selector
…, aci_access_port_selector, aci_fex_profile. aci_leaf_interface_profile, aci_spine_interface_profile and aci_spine_access_port_selector to terrform plugin framework
akinross
requested review from
anvitha-jain,
gmicol,
lhercot,
sajagana,
samiib and
shrsr
as code owners
lhercot
requested changes
Nov 11, 2025
shrsr
reviewed
Nov 12, 2025
samiib
requested changes
Nov 12, 2025
| * `name_alias` (nameAlias) - (string) The name alias of the Access Port Block object. This attribute is supported in ACI versions: 2.2(1k) and later. | ||
| * `to_card` (toCard) - (string) The end of the line card range for the Access Port Block object. | ||
| * `to_port` (toPort) - (string) The end of the port range for the Access Port Block object. | ||
| * `relation_to_pc_vpc_override_policy` - (map) A map of Relation To Pc Vpc Override Policy (ACI object [infraRsAccBndlSubgrp](https://pubhub.devnetcloud.com/media/model-doc-latest/docs/app/index.html#/objects/infraRsAccBndlSubgrp/overview)) pointing to PC VPC Override Policy (ACI Object [infraAccBndlSubgrp](https://pubhub.devnetcloud.com/media/model-doc-latest/docs/app/index.html#/objects/infraAccBndlSubgrp/overview)). |
Collaborator
There was a problem hiding this comment.
Suggested change
| * `relation_to_pc_vpc_override_policy` - (map) A map of Relation To Pc Vpc Override Policy (ACI object [infraRsAccBndlSubgrp](https://pubhub.devnetcloud.com/media/model-doc-latest/docs/app/index.html#/objects/infraRsAccBndlSubgrp/overview)) pointing to PC VPC Override Policy (ACI Object [infraAccBndlSubgrp](https://pubhub.devnetcloud.com/media/model-doc-latest/docs/app/index.html#/objects/infraAccBndlSubgrp/overview)). | |
| * `relation_to_pc_vpc_override_policy` - (map) A map of Relation To PC VPC Override Policy (ACI object [infraRsAccBndlSubgrp](https://pubhub.devnetcloud.com/media/model-doc-latest/docs/app/index.html#/objects/infraRsAccBndlSubgrp/overview)) pointing to PC VPC Override Policy (ACI Object [infraAccBndlSubgrp](https://pubhub.devnetcloud.com/media/model-doc-latest/docs/app/index.html#/objects/infraAccBndlSubgrp/overview)). |
| * `to_card` (toCard) - (string) The end of the line card range for the Access Port Block object. | ||
| * `to_port` (toPort) - (string) The end of the port range for the Access Port Block object. | ||
| * `relation_to_pc_vpc_override_policy` - (map) A map of Relation To Pc Vpc Override Policy (ACI object [infraRsAccBndlSubgrp](https://pubhub.devnetcloud.com/media/model-doc-latest/docs/app/index.html#/objects/infraRsAccBndlSubgrp/overview)) pointing to PC VPC Override Policy (ACI Object [infraAccBndlSubgrp](https://pubhub.devnetcloud.com/media/model-doc-latest/docs/app/index.html#/objects/infraAccBndlSubgrp/overview)). | ||
| * `annotation` (annotation) - (string) The annotation of the Relation To Pc Vpc Override Policy object. This attribute is supported in ACI versions: 3.2(1l) and later. |
Collaborator
There was a problem hiding this comment.
Suggested change
| * `annotation` (annotation) - (string) The annotation of the Relation To Pc Vpc Override Policy object. This attribute is supported in ACI versions: 3.2(1l) and later. | |
| * `annotation` (annotation) - (string) The annotation of the Relation To PC VPC Override Policy object. This attribute is supported in ACI versions: 3.2(1l) and later. |
docs/resources/access_port_block.md
Outdated
| * `relation_to_pc_vpc_override_policy` - (map) A map of Relation To Pc Vpc Override Policy (ACI object [infraRsAccBndlSubgrp](https://pubhub.devnetcloud.com/media/model-doc-latest/docs/app/index.html#/objects/infraRsAccBndlSubgrp/overview)) pointing to PC VPC Override Policy (ACI Object [infraAccBndlSubgrp](https://pubhub.devnetcloud.com/media/model-doc-latest/docs/app/index.html#/objects/infraAccBndlSubgrp/overview)) which can be configured using the [aci_leaf_access_bundle_policy_sub_group](https://registry.terraform.io/providers/CiscoDevNet/aci/latest/docs/resources/leaf_access_bundle_policy_sub_group) resource. | ||
| #### Optional #### | ||
|
|
||
| * `annotation` (annotation) - (string) The annotation of the Relation To Pc Vpc Override Policy object. This attribute is supported in ACI versions: 3.2(1l) and later. |
Collaborator
There was a problem hiding this comment.
Suggested change
| * `annotation` (annotation) - (string) The annotation of the Relation To Pc Vpc Override Policy object. This attribute is supported in ACI versions: 3.2(1l) and later. | |
| * `annotation` (annotation) - (string) The annotation of the Relation To PC VPC Override Policy object. This attribute is supported in ACI versions: 3.2(1l) and later. |
docs/resources/access_port_block.md
Outdated
| - Default: `"1"` | ||
| * `to_port` (toPort) - (string) The end of the port range for the Access Port Block object. | ||
| - Default: `"1"` | ||
| * `relation_to_pc_vpc_override_policy` - (map) A map of Relation To Pc Vpc Override Policy (ACI object [infraRsAccBndlSubgrp](https://pubhub.devnetcloud.com/media/model-doc-latest/docs/app/index.html#/objects/infraRsAccBndlSubgrp/overview)) pointing to PC VPC Override Policy (ACI Object [infraAccBndlSubgrp](https://pubhub.devnetcloud.com/media/model-doc-latest/docs/app/index.html#/objects/infraAccBndlSubgrp/overview)) which can be configured using the [aci_leaf_access_bundle_policy_sub_group](https://registry.terraform.io/providers/CiscoDevNet/aci/latest/docs/resources/leaf_access_bundle_policy_sub_group) resource. |
Collaborator
There was a problem hiding this comment.
Suggested change
| * `relation_to_pc_vpc_override_policy` - (map) A map of Relation To Pc Vpc Override Policy (ACI object [infraRsAccBndlSubgrp](https://pubhub.devnetcloud.com/media/model-doc-latest/docs/app/index.html#/objects/infraRsAccBndlSubgrp/overview)) pointing to PC VPC Override Policy (ACI Object [infraAccBndlSubgrp](https://pubhub.devnetcloud.com/media/model-doc-latest/docs/app/index.html#/objects/infraAccBndlSubgrp/overview)) which can be configured using the [aci_leaf_access_bundle_policy_sub_group](https://registry.terraform.io/providers/CiscoDevNet/aci/latest/docs/resources/leaf_access_bundle_policy_sub_group) resource. | |
| * `relation_to_pc_vpc_override_policy` - (map) A map of Relation To PC VPC Override Policy (ACI object [infraRsAccBndlSubgrp](https://pubhub.devnetcloud.com/media/model-doc-latest/docs/app/index.html#/objects/infraRsAccBndlSubgrp/overview)) pointing to PC VPC Override Policy (ACI Object [infraAccBndlSubgrp](https://pubhub.devnetcloud.com/media/model-doc-latest/docs/app/index.html#/objects/infraAccBndlSubgrp/overview)) which can be configured using the [aci_leaf_access_bundle_policy_sub_group](https://registry.terraform.io/providers/CiscoDevNet/aci/latest/docs/resources/leaf_access_bundle_policy_sub_group) resource. |
| properties = append(properties, getChildTarget(model, childKey, childValue, false)) | ||
| } else if property.PropertyName == "tDn" { | ||
| return getChildTarget(model, child.PkgName, "target_dn_0", true) | ||
| return getChildTarget(model, child.PkgName, "", true) |
Collaborator
There was a problem hiding this comment.
Was this change intended? I don't see that it has changed any other test files so it looks good to me.
I noticed the tDn of infraRsAccBndlSubgrp is set to an empty string hence double checking to make sure this change was also intended.
Collaborator
Author
There was a problem hiding this comment.
Yes this was intended and related to https://github.com/CiscoDevNet/terraform-provider-aci/pull/1400/files#diff-8ea0c6b1fb855545bb9a92dbc70b451672e8d463dd49b622e0ad1e22d25785acR2839-R2841, since target_dn_0 would never be accepted properly as a DN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1385