Aci no drop dscp match policy (DCNE-598) #1415
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinross
requested review from
anvitha-jain,
gmicol,
lhercot,
sajagana,
samiib and
shrsr
as code owners
github-actions
bot
changed the title
akinross
force-pushed
the
aci_no_drop_dscp_match_policy
branch
from
3cc00e5 to
9a55852
Compare
lhercot
requested changes
Jan 17, 2026
|
|
||
| func ParseVersion(rawVersion string) VersionResult { | ||
| versionRegex := regexp.MustCompile(`(\d+)\.(\d+)\((\d+)([a-z])\)`) | ||
| versionRegex := regexp.MustCompile(`((\d+)\.(\d+)\((\d+)([a-z])\)|(\d+)\.(\d+)\((\d+))`) |
Member
There was a problem hiding this comment.
Wouldn't this be simpler:
Suggested change
| versionRegex := regexp.MustCompile(`((\d+)\.(\d+)\((\d+)([a-z])\)|(\d+)\.(\d+)\((\d+))`) | |
| versionRegex := regexp.MustCompile(`(\d+)\.(\d+)\((\d+)([a-z]?)\)`) |
Collaborator
Author
There was a problem hiding this comment.
simplified and adjusted variable setting
…ot have a tag defined
…licy with resource aci_no_drop_dscp_match_interface_policy
akinross
force-pushed
the
aci_no_drop_dscp_match_policy
branch
from
4c8abc7 to
a8ea1f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.